Re: [PATCH 1/4] uprobes/powerpc: Don't clear TIF_UPROBE in do_notify_resume()

[Srikar Dronamraju <srikar@linux.vnet.ibm.com>]

* Ananth N Mavinakayanahalli <ananth@in.ibm.com> [2012-10-29 10:57:07]:

> On Sun, Oct 28, 2012 at 06:39:25PM +0100, Oleg Nesterov wrote:
> 
> Hi Oleg,
> 
> > Cleanup. No need to clear TIF_UPROBE, do_notify_resume() does this.
> > 
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
> > ---
> >  arch/powerpc/kernel/signal.c |    4 +---
> >  1 files changed, 1 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c
> > index a2dc757..3b99711 100644
> > --- a/arch/powerpc/kernel/signal.c
> > +++ b/arch/powerpc/kernel/signal.c
> > @@ -158,10 +158,8 @@ static int do_signal(struct pt_regs *regs)
> > 
> >  void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
> 
> But this _is_ do_notify_resume()... I don't see this flag cleared
> anywhere else.
> 
> Did you have something else in mind?

uprobe_notify_resume() itself clears TIF_UPROBES.

This change is already part of -tip but not mainline.
Hence you might have missed it.

> >  {
> > -	if (thread_info_flags & _TIF_UPROBE) {
> > -		clear_thread_flag(TIF_UPROBE);
> > +	if (thread_info_flags & _TIF_UPROBE)
> >  		uprobe_notify_resume(regs);
> > -	}
> > 
> >  	if (thread_info_flags & _TIF_SIGPENDING)
> >  		do_signal(regs);