mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const
Date: Fri, 7 Dec 2012 22:49:51 +0000	[thread overview]
Message-ID: <20121207224949.GA6179@gmail.com> (raw)
In-Reply-To: <3c1e54bc-31ec-4a38-b6d3-58b25760f9cb@email.android.com>

On Fri, Dec 07, 2012 at 02:45:43PM -0800, H. Peter Anvin wrote:
> Patch description please?
there are 2 consts in the definition of one variable

- cong
> 
> Cong Ding <dinggnu@gmail.com> wrote:
> 
> >
> >Signed-off-by: Cong Ding <dinggnu@gmail.com>
> >---
> > arch/x86/tools/gen-insn-attr-x86.awk |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/arch/x86/tools/gen-insn-attr-x86.awk
> >b/arch/x86/tools/gen-insn-attr-x86.awk
> >index ddcf39b..d1d9cfa 100644
> >--- a/arch/x86/tools/gen-insn-attr-x86.awk
> >+++ b/arch/x86/tools/gen-insn-attr-x86.awk
> >@@ -356,7 +356,7 @@ END {
> > 		exit 1
> > 	# print escape opcode map's array
> > 	print "/* Escape opcode map array */"
> >-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]"
> >\
> >+	print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \
> > 	      "[INAT_LSTPFX_MAX + 1] = {"
> > 	for (i = 0; i < geid; i++)
> > 		for (j = 0; j < max_lprefix; j++)
> >@@ -365,7 +365,7 @@ END {
> > 	print "};\n"
> > 	# print group opcode map's array
> > 	print "/* Group opcode map array */"
> >-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
> >+	print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\
> > 	      "[INAT_LSTPFX_MAX + 1] = {"
> > 	for (i = 0; i < ggid; i++)
> > 		for (j = 0; j < max_lprefix; j++)
> 
> -- 
> Sent from my mobile phone. Please excuse brevity and lack of formatting.

  reply	other threads:[~2012-12-07 22:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 22:42 Cong Ding
2012-12-07 22:45 ` H. Peter Anvin
2012-12-07 22:49   ` Cong Ding [this message]
2012-12-07 22:56     ` H. Peter Anvin
2012-12-07 23:03       ` Cong Ding
2012-12-07 23:06         ` H. Peter Anvin
2012-12-07 23:17           ` [PATCH v2] " Cong Ding
2012-12-07 23:28             ` H. Peter Anvin
2012-12-08  0:04             ` [tip:x86/cleanups] x86: Remove duplicate "const" in gen-insn-attr-x86.awk tip-bot for Cong Ding
2012-12-09  5:24             ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Masami Hiramatsu
2012-12-09  8:21               ` [PATCH v3] x86: fix the error of using "const" in gen-insn-attr-x86.awk Cong Ding
2012-12-10 21:17                 ` [tip:x86/cleanups] x86: Fix " tip-bot for Cong Ding
2012-12-09  8:27               ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-09 15:50               ` H. Peter Anvin
2012-12-10  1:00                 ` Masami Hiramatsu
2012-12-10  1:03                   ` H. Peter Anvin
2012-12-10  1:27                     ` Masami Hiramatsu
2012-12-10  1:34                       ` H. Peter Anvin
2012-12-10  1:50                         ` Masami Hiramatsu
2012-12-10  1:56                           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121207224949.GA6179@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome