From: tip-bot for Cong Ding <dinggnu@gmail.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
masami.hiramatsu.pt@hitachi.com, dinggnu@gmail.com,
tglx@linutronix.de, hpa@linux.intel.com
Subject: [tip:x86/cleanups] x86: Fix the error of using "const" in gen-insn-attr-x86.awk
Date: Mon, 10 Dec 2012 13:17:03 -0800 [thread overview]
Message-ID: <tip-28a793892296ca3367193c7a7de1714f80049fd0@git.kernel.org> (raw)
In-Reply-To: <20121209082103.GA9181@gmail.com>
Commit-ID: 28a793892296ca3367193c7a7de1714f80049fd0
Gitweb: http://git.kernel.org/tip/28a793892296ca3367193c7a7de1714f80049fd0
Author: Cong Ding <dinggnu@gmail.com>
AuthorDate: Sun, 9 Dec 2012 08:21:04 +0000
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Mon, 10 Dec 2012 10:31:24 -0800
x86: Fix the error of using "const" in gen-insn-attr-x86.awk
The original version code causes following sparse warnings:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const
arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const
arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const
for the variables inat_escape_tables, inat_group_tables, and inat_avx_tables
in the code generated by gen-insn-attr-x86.awk.
The author Masami Hiramutsu says here is to make both the value pointed by the
pointers and the pointers itself read-only, so we move the "const" to be after
the "*".
Signed-off-by: Cong Ding <dinggnu@gmail.com>
Link: http://lkml.kernel.org/r/20121209082103.GA9181@gmail.com
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/tools/gen-insn-attr-x86.awk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/tools/gen-insn-attr-x86.awk b/arch/x86/tools/gen-insn-attr-x86.awk
index ddcf39b..e6773dc 100644
--- a/arch/x86/tools/gen-insn-attr-x86.awk
+++ b/arch/x86/tools/gen-insn-attr-x86.awk
@@ -356,7 +356,7 @@ END {
exit 1
# print escape opcode map's array
print "/* Escape opcode map array */"
- print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]" \
+ print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1]" \
"[INAT_LSTPFX_MAX + 1] = {"
for (i = 0; i < geid; i++)
for (j = 0; j < max_lprefix; j++)
@@ -365,7 +365,7 @@ END {
print "};\n"
# print group opcode map's array
print "/* Group opcode map array */"
- print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
+ print "const insn_attr_t * const inat_group_tables[INAT_GRP_MAX + 1]"\
"[INAT_LSTPFX_MAX + 1] = {"
for (i = 0; i < ggid; i++)
for (j = 0; j < max_lprefix; j++)
@@ -374,7 +374,7 @@ END {
print "};\n"
# print AVX opcode map's array
print "/* AVX opcode map array */"
- print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX + 1]"\
+ print "const insn_attr_t * const inat_avx_tables[X86_VEX_M_MAX + 1]"\
"[INAT_LSTPFX_MAX + 1] = {"
for (i = 0; i < gaid; i++)
for (j = 0; j < max_lprefix; j++)
next prev parent reply other threads:[~2012-12-10 21:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 22:42 [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-07 22:45 ` H. Peter Anvin
2012-12-07 22:49 ` Cong Ding
2012-12-07 22:56 ` H. Peter Anvin
2012-12-07 23:03 ` Cong Ding
2012-12-07 23:06 ` H. Peter Anvin
2012-12-07 23:17 ` [PATCH v2] " Cong Ding
2012-12-07 23:28 ` H. Peter Anvin
2012-12-08 0:04 ` [tip:x86/cleanups] x86: Remove duplicate "const" in gen-insn-attr-x86.awk tip-bot for Cong Ding
2012-12-09 5:24 ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Masami Hiramatsu
2012-12-09 8:21 ` [PATCH v3] x86: fix the error of using "const" in gen-insn-attr-x86.awk Cong Ding
2012-12-10 21:17 ` tip-bot for Cong Ding [this message]
2012-12-09 8:27 ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-09 15:50 ` H. Peter Anvin
2012-12-10 1:00 ` Masami Hiramatsu
2012-12-10 1:03 ` H. Peter Anvin
2012-12-10 1:27 ` Masami Hiramatsu
2012-12-10 1:34 ` H. Peter Anvin
2012-12-10 1:50 ` Masami Hiramatsu
2012-12-10 1:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-28a793892296ca3367193c7a7de1714f80049fd0@git.kernel.org \
--to=dinggnu@gmail.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®