From: "H. Peter Anvin" <hpa@zytor.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const
Date: Fri, 07 Dec 2012 15:06:13 -0800 [thread overview]
Message-ID: <50C27665.4090206@zytor.com> (raw)
In-Reply-To: <20121207230302.GB6179@gmail.com>
On 12/07/2012 03:03 PM, Cong Ding wrote:
> On Fri, Dec 07, 2012 at 02:56:16PM -0800, H. Peter Anvin wrote:
>> On 12/07/2012 02:49 PM, Cong Ding wrote:
>>> On Fri, Dec 07, 2012 at 02:45:43PM -0800, H. Peter Anvin wrote:
>>>> Patch description please?
>>> there are 2 consts in the definition of one variable
>>>
>>
>> Please put in an actual patch description. The first line (subject
>> line) is a title; the patch should make sense without it.
> sorry for that. so like this is fine?
>
Well, except that typically you should explain which variable it is.
Yes, it is obvious if you look at the patch, but you're making the
reader spend a few more moments than necessary.
Also, you should explain what the harm is -- if it breaks anything or is
just a cosmetic issue.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-12-07 23:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 22:42 Cong Ding
2012-12-07 22:45 ` H. Peter Anvin
2012-12-07 22:49 ` Cong Ding
2012-12-07 22:56 ` H. Peter Anvin
2012-12-07 23:03 ` Cong Ding
2012-12-07 23:06 ` H. Peter Anvin [this message]
2012-12-07 23:17 ` [PATCH v2] " Cong Ding
2012-12-07 23:28 ` H. Peter Anvin
2012-12-08 0:04 ` [tip:x86/cleanups] x86: Remove duplicate "const" in gen-insn-attr-x86.awk tip-bot for Cong Ding
2012-12-09 5:24 ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Masami Hiramatsu
2012-12-09 8:21 ` [PATCH v3] x86: fix the error of using "const" in gen-insn-attr-x86.awk Cong Ding
2012-12-10 21:17 ` [tip:x86/cleanups] x86: Fix " tip-bot for Cong Ding
2012-12-09 8:27 ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-09 15:50 ` H. Peter Anvin
2012-12-10 1:00 ` Masami Hiramatsu
2012-12-10 1:03 ` H. Peter Anvin
2012-12-10 1:27 ` Masami Hiramatsu
2012-12-10 1:34 ` H. Peter Anvin
2012-12-10 1:50 ` Masami Hiramatsu
2012-12-10 1:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C27665.4090206@zytor.com \
--to=hpa@zytor.com \
--cc=dinggnu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome