mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: libc-alpha@sourceware.org
Cc: David Miller <davem@davemloft.net>,
	bhutchings@solarflare.com, yoshfuji@linux-ipv6.org,
	amwang@redhat.com, tmb@mageia.org, eblake@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	libvirt-list@redhat.com, tgraf@suug.ch, schwab@suse.de,
	carlos@systemhalted.org
Subject: Re: Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h>
Date: Thu, 17 Jan 2013 23:14:31 -0500	[thread overview]
Message-ID: <201301172314.34193.vapier@gentoo.org> (raw)
In-Reply-To: <20130116.164511.2027039182184636075.davem@davemloft.net>

[-- Attachment #1: Type: Text/Plain, Size: 1034 bytes --]

On Wednesday 16 January 2013 16:45:11 David Miller wrote:
> What would be really nice is if GCC treated multiple identical
> definitions of structures the same way it handles multiple identical
> definitions of CPP defines.  Which is to silently accept them.
> 
> But that's not the case, so we need a different solution.
> 
> Another thing to do is to use a new structure for in6_addr in kernel
> headers exported to userland.

the kernel already exports many types with a __kernel_ prefix.  i changed the 
kernel headers in Gentoo for a few releases (2.6.28 - 2.6.34) to do the same 
thing to pretty much all the networking headers.  a few packages broke, but 
the number was low, and trivial to fix (a sed would do it most of the time).

it's also trivial for userland packages to detect that they need to do this 
sort of thing in a local header by using linux/version.h and a set of defines 
to redirect the new structure name back to the old one.

would be a lot cleaner to just break it and be done.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-01-18  4:11 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 18:38 if_bridge.h: include in6.h for struct in6_addr use Thomas Backlund
2013-01-13 20:05 ` Thomas Backlund
2013-01-14 23:57   ` [libvirt] " Eric Blake
2013-01-15 10:03     ` the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi (was: Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use) Thomas Backlund
2013-01-15 10:11       ` Cong Wang
2013-01-15 10:55         ` the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi Thomas Backlund
2013-01-16  5:51           ` Cong Wang
2013-01-16  6:06           ` Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h> Cong Wang
2013-01-16 14:21             ` YOSHIFUJI Hideaki
2013-01-16 15:47               ` Ben Hutchings
2013-01-16 17:04                 ` Mike Frysinger
2013-01-16 17:10                   ` Ben Hutchings
2013-01-16 17:28                     ` Mike Frysinger
2013-01-16 18:59                       ` David Miller
2013-01-16 19:22                         ` Mike Frysinger
2013-01-16 19:25                           ` David Miller
2013-01-17  3:40                           ` Cong Wang
     [not found]                         ` <CANE52KhF17WRZTUbrjRDnwcbdN+V+69=ZqXjBwPjnswEO5iz7g@mail.gmail.com>
2013-01-17  6:59                           ` Cong Wang
2013-01-17  7:02                             ` Cong Wang
2013-01-16 18:57                   ` David Miller
2013-01-16 19:29                     ` Mike Frysinger
2013-01-17  2:15                     ` Carlos O'Donell
2013-01-17  3:10                       ` YOSHIFUJI Hideaki
2013-01-17  3:15                       ` David Miller
2013-01-18  4:20                         ` Mike Frysinger
2013-01-18  4:22                           ` Carlos O'Donell
2013-01-18  4:34                             ` Mike Frysinger
2013-01-18 10:44                             ` Pedro Alves
2013-01-18 13:35                               ` Carlos O'Donell
2013-01-18 14:24                                 ` YOSHIFUJI Hideaki
2013-01-18 14:36                                   ` Pedro Alves
2013-01-18 14:54                                     ` Carlos O'Donell
2013-01-21  0:54                                     ` Mike Frysinger
2013-01-17  3:22                       ` YOSHIFUJI Hideaki
2013-01-18  4:13                         ` Carlos O'Donell
2013-01-16 21:45                 ` David Miller
2013-01-17  1:58                   ` Carlos O'Donell
2013-01-17  2:05                     ` David Miller
2013-01-17 10:57                       ` Jan Engelhardt
2013-01-18  4:14                   ` Mike Frysinger [this message]
2013-01-18  4:55                     ` David Miller
2013-01-18  5:27                       ` Mike Frysinger
2013-03-13 15:17     ` [libvirt] if_bridge.h: include in6.h for struct in6_addr use Kumar Gala
2013-03-13 16:24       ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301172314.34193.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=amwang@redhat.com \
    --cc=bhutchings@solarflare.com \
    --cc=carlos@systemhalted.org \
    --cc=davem@davemloft.net \
    --cc=eblake@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=libvirt-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=schwab@suse.de \
    --cc=tgraf@suug.ch \
    --cc=tmb@mageia.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome