mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: Eric Blake <eblake@redhat.com>
Cc: Thomas Backlund <tmb@mageia.org>,
	netdev@vger.kernel.org,
	"linux-kernel@vger.kernel.org list"
	<linux-kernel@vger.kernel.org>,
	libvirt-list@redhat.com, stephen@networkplumber.org,
	Zhenhua Luo <zhenhua.luo@freescale.com>
Subject: Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use
Date: Wed, 13 Mar 2013 10:17:40 -0500	[thread overview]
Message-ID: <81B30F90-5A18-4386-9C30-E336AE212D85@kernel.crashing.org> (raw)
In-Reply-To: <50F49B7E.50906@redhat.com>


On Jan 14, 2013, at 5:57 PM, Eric Blake wrote:

> On 01/13/2013 01:05 PM, Thomas Backlund wrote:
>> Thomas Backlund skrev 13.1.2013 20:38:
>>> patch both inline and attached as thunderbird tends to mess up ...
>> 
>>> -----
>>> 
>>> if_bridge.h uses struct in6_addr ip6; but does not include the in6.h
>>> header.
>>> 
>>> Found by trying to build libvirt and connman against 3.8-rc3 headers.
>>> 
>> 
>> Ok,
>> ignore this patch, it's not the correct fix as it introduces
>> redefinitions...
>> 
>> Btw, the error that I hit that made me suggest this fix was libvirt
>> config check bailing out:
>> 
>> config.log:/usr/include/linux/if_bridge.h:173:20: error: field 'ip6' has
>> incomplete type
> 
> Hmm, just now noticing this thread, after independently hitting and and
> having to work around the same problem in libvirt:
> https://www.redhat.com/archives/libvir-list/2013-January/msg00930.html
> https://bugzilla.redhat.com/show_bug.cgi?id=895141
> 
>>> --- linux-3.8-rc3/include/uapi/linux/if_bridge.h        2013-01-13
>>> 20:09:54.257271755 +0200
>>> +++ linux-3.8-rc3.fix/include/uapi/linux/if_bridge.h    2013-01-13
>>> 20:15:04.153676151 +0200
>>> @@ -14,6 +14,7 @@
>>>  #define _UAPI_LINUX_IF_BRIDGE_H
>>> 
>>>  #include <linux/types.h>
>>> +#include <linux/in6.h>
>>> 

Did this ever get resolved ?

- k


  parent reply	other threads:[~2013-03-13 15:17 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13 18:38 Thomas Backlund
2013-01-13 20:05 ` Thomas Backlund
2013-01-14 23:57   ` [libvirt] " Eric Blake
2013-01-15 10:03     ` the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi (was: Re: [libvirt] if_bridge.h: include in6.h for struct in6_addr use) Thomas Backlund
2013-01-15 10:11       ` Cong Wang
2013-01-15 10:55         ` the patch "bridge: export multicast database via netlink" broke kernel 3.8 uapi Thomas Backlund
2013-01-16  5:51           ` Cong Wang
2013-01-16  6:06           ` Redefinition of struct in6_addr in <netinet/in.h> and <linux/in6.h> Cong Wang
2013-01-16 14:21             ` YOSHIFUJI Hideaki
2013-01-16 15:47               ` Ben Hutchings
2013-01-16 17:04                 ` Mike Frysinger
2013-01-16 17:10                   ` Ben Hutchings
2013-01-16 17:28                     ` Mike Frysinger
2013-01-16 18:59                       ` David Miller
2013-01-16 19:22                         ` Mike Frysinger
2013-01-16 19:25                           ` David Miller
2013-01-17  3:40                           ` Cong Wang
     [not found]                         ` <CANE52KhF17WRZTUbrjRDnwcbdN+V+69=ZqXjBwPjnswEO5iz7g@mail.gmail.com>
2013-01-17  6:59                           ` Cong Wang
2013-01-17  7:02                             ` Cong Wang
2013-01-16 18:57                   ` David Miller
2013-01-16 19:29                     ` Mike Frysinger
2013-01-17  2:15                     ` Carlos O'Donell
2013-01-17  3:10                       ` YOSHIFUJI Hideaki
2013-01-17  3:15                       ` David Miller
2013-01-18  4:20                         ` Mike Frysinger
2013-01-18  4:22                           ` Carlos O'Donell
2013-01-18  4:34                             ` Mike Frysinger
2013-01-18 10:44                             ` Pedro Alves
2013-01-18 13:35                               ` Carlos O'Donell
2013-01-18 14:24                                 ` YOSHIFUJI Hideaki
2013-01-18 14:36                                   ` Pedro Alves
2013-01-18 14:54                                     ` Carlos O'Donell
2013-01-21  0:54                                     ` Mike Frysinger
2013-01-17  3:22                       ` YOSHIFUJI Hideaki
2013-01-18  4:13                         ` Carlos O'Donell
2013-01-16 21:45                 ` David Miller
2013-01-17  1:58                   ` Carlos O'Donell
2013-01-17  2:05                     ` David Miller
2013-01-17 10:57                       ` Jan Engelhardt
2013-01-18  4:14                   ` Mike Frysinger
2013-01-18  4:55                     ` David Miller
2013-01-18  5:27                       ` Mike Frysinger
2013-03-13 15:17     ` Kumar Gala [this message]
2013-03-13 16:24       ` [libvirt] if_bridge.h: include in6.h for struct in6_addr use Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81B30F90-5A18-4386-9C30-E336AE212D85@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=eblake@redhat.com \
    --cc=libvirt-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=tmb@mageia.org \
    --cc=zhenhua.luo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®