* [PATCH] da9030_battery: include notifier.h
@ 2013-02-06 9:14 Michal Hocko
2013-02-06 14:09 ` Michal Hocko
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2013-02-06 9:14 UTC (permalink / raw)
To: linux-kernel; +Cc: Anton Vorontsov, David Woodhouse, Axel Lin
randconfig complains about:
drivers/power/da9030_battery.c:113: error: field ‘nb’ has incomplete type
because there is no direct include for notifier.h which defines
struct notifier_block.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
---
drivers/power/da9030_battery.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
index 94762e6..e8c5a39 100644
--- a/drivers/power/da9030_battery.c
+++ b/drivers/power/da9030_battery.c
@@ -22,6 +22,7 @@
#include <linux/debugfs.h>
#include <linux/seq_file.h>
+#include <linux/notifier.h>
#define DA9030_FAULT_LOG 0x0a
#define DA9030_FAULT_LOG_OVER_TEMP (1 << 7)
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] da9030_battery: include notifier.h
2013-02-06 9:14 [PATCH] da9030_battery: include notifier.h Michal Hocko
@ 2013-02-06 14:09 ` Michal Hocko
2013-02-09 1:45 ` Anton Vorontsov
0 siblings, 1 reply; 3+ messages in thread
From: Michal Hocko @ 2013-02-06 14:09 UTC (permalink / raw)
To: linux-kernel; +Cc: Anton Vorontsov, David Woodhouse, Axel Lin, Andrew Morton
Ohh, I have just noticed that this could be introduced by "mm: break
circular include from linux/mmzone.h" in mm tree.
Adding Andrew to CC.
On Wed 06-02-13 10:14:58, Michal Hocko wrote:
> randconfig complains about:
> drivers/power/da9030_battery.c:113: error: field ‘nb’ has incomplete type
>
> because there is no direct include for notifier.h which defines
> struct notifier_block.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> ---
> drivers/power/da9030_battery.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
> index 94762e6..e8c5a39 100644
> --- a/drivers/power/da9030_battery.c
> +++ b/drivers/power/da9030_battery.c
> @@ -22,6 +22,7 @@
>
> #include <linux/debugfs.h>
> #include <linux/seq_file.h>
> +#include <linux/notifier.h>
>
> #define DA9030_FAULT_LOG 0x0a
> #define DA9030_FAULT_LOG_OVER_TEMP (1 << 7)
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] da9030_battery: include notifier.h
2013-02-06 14:09 ` Michal Hocko
@ 2013-02-09 1:45 ` Anton Vorontsov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2013-02-09 1:45 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-kernel, David Woodhouse, Axel Lin, Andrew Morton
On Wed, Feb 06, 2013 at 03:09:59PM +0100, Michal Hocko wrote:
> Ohh, I have just noticed that this could be introduced by "mm: break
> circular include from linux/mmzone.h" in mm tree.
> Adding Andrew to CC.
The patch is legit, actually. So, I've applied it, thank you!
Anton
> On Wed 06-02-13 10:14:58, Michal Hocko wrote:
> > randconfig complains about:
> > drivers/power/da9030_battery.c:113: error: field ‘nb’ has incomplete type
> >
> > because there is no direct include for notifier.h which defines
> > struct notifier_block.
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
> > ---
> > drivers/power/da9030_battery.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
> > index 94762e6..e8c5a39 100644
> > --- a/drivers/power/da9030_battery.c
> > +++ b/drivers/power/da9030_battery.c
> > @@ -22,6 +22,7 @@
> >
> > #include <linux/debugfs.h>
> > #include <linux/seq_file.h>
> > +#include <linux/notifier.h>
> >
> > #define DA9030_FAULT_LOG 0x0a
> > #define DA9030_FAULT_LOG_OVER_TEMP (1 << 7)
> > --
> > 1.7.10.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> --
> Michal Hocko
> SUSE Labs
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-09 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 9:14 [PATCH] da9030_battery: include notifier.h Michal Hocko
2013-02-06 14:09 ` Michal Hocko
2013-02-09 1:45 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®