* [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes
@ 2013-03-14 8:27 Axel Lin
2013-03-14 10:23 ` Jean Delvare
0 siblings, 1 reply; 4+ messages in thread
From: Axel Lin @ 2013-03-14 8:27 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck; +Cc: lm-sensors, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/hwmon/lineage-pem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
index 41df29f..ebbb9f4 100644
--- a/drivers/hwmon/lineage-pem.c
+++ b/drivers/hwmon/lineage-pem.c
@@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = {
&sensor_dev_attr_in2_input.dev_attr.attr,
&sensor_dev_attr_curr1_input.dev_attr.attr,
&sensor_dev_attr_power1_input.dev_attr.attr,
+ NULL
};
static const struct attribute_group pem_input_group = {
@@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = {
&sensor_dev_attr_fan1_input.dev_attr.attr,
&sensor_dev_attr_fan2_input.dev_attr.attr,
&sensor_dev_attr_fan3_input.dev_attr.attr,
+ NULL
};
static const struct attribute_group pem_fan_group = {
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes
2013-03-14 8:27 [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes Axel Lin
@ 2013-03-14 10:23 ` Jean Delvare
2013-03-14 13:33 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Jean Delvare @ 2013-03-14 10:23 UTC (permalink / raw)
To: Axel Lin; +Cc: Guenter Roeck, lm-sensors, linux-kernel
Hi Axel,
On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/hwmon/lineage-pem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
> index 41df29f..ebbb9f4 100644
> --- a/drivers/hwmon/lineage-pem.c
> +++ b/drivers/hwmon/lineage-pem.c
> @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = {
> &sensor_dev_attr_in2_input.dev_attr.attr,
> &sensor_dev_attr_curr1_input.dev_attr.attr,
> &sensor_dev_attr_power1_input.dev_attr.attr,
> + NULL
> };
>
> static const struct attribute_group pem_input_group = {
> @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = {
> &sensor_dev_attr_fan1_input.dev_attr.attr,
> &sensor_dev_attr_fan2_input.dev_attr.attr,
> &sensor_dev_attr_fan3_input.dev_attr.attr,
> + NULL
> };
>
> static const struct attribute_group pem_fan_group = {
Good catch.
Acked-by: Jean Delvare <khali@linux-fr.org>
I'll let Guenter pick the fix as this is his driver. This should go to
stable too.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes
2013-03-14 10:23 ` Jean Delvare
@ 2013-03-14 13:33 ` Guenter Roeck
2013-03-14 15:08 ` Jean Delvare
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2013-03-14 13:33 UTC (permalink / raw)
To: Jean Delvare; +Cc: Axel Lin, lm-sensors, linux-kernel
On Thu, Mar 14, 2013 at 11:23:54AM +0100, Jean Delvare wrote:
> Hi Axel,
>
> On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote:
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > drivers/hwmon/lineage-pem.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
> > index 41df29f..ebbb9f4 100644
> > --- a/drivers/hwmon/lineage-pem.c
> > +++ b/drivers/hwmon/lineage-pem.c
> > @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = {
> > &sensor_dev_attr_in2_input.dev_attr.attr,
> > &sensor_dev_attr_curr1_input.dev_attr.attr,
> > &sensor_dev_attr_power1_input.dev_attr.attr,
> > + NULL
> > };
> >
> > static const struct attribute_group pem_input_group = {
> > @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = {
> > &sensor_dev_attr_fan1_input.dev_attr.attr,
> > &sensor_dev_attr_fan2_input.dev_attr.attr,
> > &sensor_dev_attr_fan3_input.dev_attr.attr,
> > + NULL
> > };
> >
> > static const struct attribute_group pem_fan_group = {
>
> Good catch.
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> I'll let Guenter pick the fix as this is his driver. This should go to
> stable too.
>
Will do. Just wonder why this never blew up in my face, as we use that driver
in my previous company :).
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes
2013-03-14 13:33 ` Guenter Roeck
@ 2013-03-14 15:08 ` Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2013-03-14 15:08 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Axel Lin, lm-sensors, linux-kernel
On Thu, 14 Mar 2013 06:33:04 -0700, Guenter Roeck wrote:
> On Thu, Mar 14, 2013 at 11:23:54AM +0100, Jean Delvare wrote:
> > Hi Axel,
> >
> > On Thu, 14 Mar 2013 16:27:18 +0800, Axel Lin wrote:
> > > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > > ---
> > > drivers/hwmon/lineage-pem.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/hwmon/lineage-pem.c b/drivers/hwmon/lineage-pem.c
> > > index 41df29f..ebbb9f4 100644
> > > --- a/drivers/hwmon/lineage-pem.c
> > > +++ b/drivers/hwmon/lineage-pem.c
> > > @@ -422,6 +422,7 @@ static struct attribute *pem_input_attributes[] = {
> > > &sensor_dev_attr_in2_input.dev_attr.attr,
> > > &sensor_dev_attr_curr1_input.dev_attr.attr,
> > > &sensor_dev_attr_power1_input.dev_attr.attr,
> > > + NULL
> > > };
> > >
> > > static const struct attribute_group pem_input_group = {
> > > @@ -432,6 +433,7 @@ static struct attribute *pem_fan_attributes[] = {
> > > &sensor_dev_attr_fan1_input.dev_attr.attr,
> > > &sensor_dev_attr_fan2_input.dev_attr.attr,
> > > &sensor_dev_attr_fan3_input.dev_attr.attr,
> > > + NULL
> > > };
> > >
> > > static const struct attribute_group pem_fan_group = {
> >
> > Good catch.
> >
> > Acked-by: Jean Delvare <khali@linux-fr.org>
> >
> > I'll let Guenter pick the fix as this is his driver. This should go to
> > stable too.
>
> Will do. Just wonder why this never blew up in my face, as we use that driver
> in my previous company :).
I've seen it before. I suspect we are saved by the fact that the first
member of struct attribute_group is const char *name, which is almost
never set in the hwmon drivers.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-14 15:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-14 8:27 [PATCH] hwmon: lineage-pem: Add missing terminating entry for pem_[input|fan]_attributes Axel Lin
2013-03-14 10:23 ` Jean Delvare
2013-03-14 13:33 ` Guenter Roeck
2013-03-14 15:08 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®