[PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

[PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

[Paul Bolle]

CONFIG_EXPERIMENTAL has been removed from the tree, in commit
3d374d09f16f64ab4d71704cbe621514d36cd0b1 ("final removal of
CONFIG_EXPERIMENTAL"). There's no need to test for it in checkpatch
anymore. If it ever pops up again it can be caught when someone feels
like cleaning up invalid Kconfig symbols and macros again.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Checkpatch tested!

1) A lot of defconfigs still have CONFIG_EXPERIMENTAL in them. How
should that be cleaned up?

 scripts/checkpatch.pl | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b28cc38..de8b1ff 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1745,13 +1745,6 @@ sub process {
 			#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
 		}
 
-# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
-		if ($realfile =~ /Kconfig/ &&
-		    $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
-			WARN("CONFIG_EXPERIMENTAL",
-			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
-		}
-
 		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
 		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
 			my $flag = $1;
@@ -1907,12 +1900,6 @@ sub process {
 # check we are in a valid C source file if not then ignore this hunk
 		next if ($realfile !~ /\.(h|c)$/);
 
-# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
-		if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
-			WARN("CONFIG_EXPERIMENTAL",
-			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
-		}
-
 # check for RCS/CVS revision markers
 		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
 			WARN("CVS_KEYWORD",
-- 
1.7.11.7

Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

[Greg Kroah-Hartman]

On Sat, Mar 16, 2013 at 10:30:35PM +0100, Paul Bolle wrote:
> 1) A lot of defconfigs still have CONFIG_EXPERIMENTAL in them. How
> should that be cleaned up?

Just ignore it, when ever those defconfigs ever get used, or updated, it
will fall out automatically.

thanks,

greg k-h

Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

[Kees Cook]

On Sat, Mar 16, 2013 at 2:30 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> CONFIG_EXPERIMENTAL has been removed from the tree, in commit
> 3d374d09f16f64ab4d71704cbe621514d36cd0b1 ("final removal of
> CONFIG_EXPERIMENTAL"). There's no need to test for it in checkpatch
> anymore. If it ever pops up again it can be caught when someone feels
> like cleaning up invalid Kconfig symbols and macros again.

Hrm, I actually think it would be better to change this to ERROR
instead of WARN.

-Kees

-- 
Kees Cook
Chrome OS Security

Re: [PATCH] checkpatch: stop checking for CONFIG_EXPERIMENTAL

[Paul Bolle]

On Sat, 2013-03-16 at 15:38 -0700, Kees Cook wrote:
> Hrm, I actually think it would be better to change this to ERROR
> instead of WARN.

I figured the main reason to add this warning was to prevent people to
add dependencies on EXPERIMENTAL while you were cleaning the tree, which
could mean you had to redo patches each time that happened.

Anyhow, with EXPERIMENTAL gone, this is just one of the mistakes people
can make in using the kconfig system. I'm not sure that we should use
checkpatch to catch these. For this particular case it must also be
noted that if code gets in while still depending on EXPERIMENTAL someone
also missed that this code doesn't get build at all.


Paul Bolle