From: Oskar Andero <oskar.andero@sonymobile.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"Makarov, Aleksej" <Aleksej.Makarov@sonymobile.com>,
Radovan Lekanovic <radovan.lekanovic@sonymobile.com>
Subject: Re: [PATCH] input: don't call input_dev_release_keys() in resume
Date: Thu, 4 Apr 2013 16:57:02 +0200 [thread overview]
Message-ID: <20130404145702.GE2481@caracas.corpusers.net> (raw)
In-Reply-To: <1362664882-16194-1-git-send-email-oskar.andero@sonymobile.com>
On 15:01 Thu 07 Mar , oskar.andero@sonymobile.com wrote:
> From: Aleksej Makarov <aleksej.makarov@sonymobile.com>
>
> When waking up the platform by pressing a specific key, sending a
> release on that key makes it impossible to react on the event in
> user-space.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Reviewed-by: Radovan Lekanovic <radovan.lekanovic@sonymobile.com>
> Signed-off-by: Aleksej Makarov <aleksej.makarov@sonymobile.com>
> Signed-off-by: Oskar Andero <oskar.andero@sonymobile.com>
> ---
> drivers/input/input.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index c044699..61ce19f 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -1690,7 +1690,10 @@ static int input_dev_resume(struct device *dev)
> {
> struct input_dev *input_dev = to_input_dev(dev);
>
> - input_reset_device(input_dev);
> + mutex_lock(&input_dev->mutex);
> + if (input_dev->users)
> + input_dev_toggle(input_dev, true);
> + mutex_unlock(&input_dev->mutex);
>
> return 0;
> }
> --
> 1.7.8.6
>
Ping. Any input on the patch above?
-Oskar
next prev parent reply other threads:[~2013-04-04 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 14:01 oskar.andero
2013-04-04 14:57 ` Oskar Andero [this message]
2013-04-04 16:33 ` Dmitry Torokhov
2013-04-05 8:57 ` Oskar Andero
2013-07-05 7:46 ` Oskar Andero
2013-07-12 7:44 ` Oskar Andero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404145702.GE2481@caracas.corpusers.net \
--to=oskar.andero@sonymobile.com \
--cc=Aleksej.Makarov@sonymobile.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radovan.lekanovic@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome