mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: oskar.andero@sonymobile.com
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Aleksej Makarov <aleksej.makarov@sonymobile.com>
Subject: Re: [PATCH] input: don't call input_dev_release_keys() in resume
Date: Thu, 4 Apr 2013 09:33:13 -0700	[thread overview]
Message-ID: <20130404163313.GA12302@core.coreip.homeip.net> (raw)
In-Reply-To: <1362664882-16194-1-git-send-email-oskar.andero@sonymobile.com>

Hi Oskar,

On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.andero@sonymobile.com wrote:
> From: Aleksej Makarov <aleksej.makarov@sonymobile.com>
> 
> When waking up the platform by pressing a specific key, sending a
> release on that key makes it impossible to react on the event in
> user-space.
> 

No, we can not simply not release keys after resume from suspend, as
this leads to keys being stuck. Consider you are holding an 'I' key on
your external USB keyboard and close your laptop's lid. Then you release
the key and leave. Later you come back, open the lid waking the laptop
and observe endless stream of 'I' in your open terminal.

Maybe we should release the keys during suspend time? I am not sure how
Android infrastructure will react to this though...

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2013-04-04 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 14:01 oskar.andero
2013-04-04 14:57 ` Oskar Andero
2013-04-04 16:33 ` Dmitry Torokhov [this message]
2013-04-05  8:57   ` Oskar Andero
2013-07-05  7:46   ` Oskar Andero
2013-07-12  7:44     ` Oskar Andero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130404163313.GA12302@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=aleksej.makarov@sonymobile.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oskar.andero@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome