From: Mark Brown <broonie@kernel.org>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Oskar Schirmer <oskar@scara.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH v2] sound/sgtl5000: fix codec register initial values and mask
Date: Wed, 12 Jun 2013 17:08:05 +0100 [thread overview]
Message-ID: <20130612160805.GL1403@sirena.org.uk> (raw)
In-Reply-To: <51B749F5.3010907@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Tue, Jun 11, 2013 at 01:01:57PM -0300, Fabio Estevam wrote:
> On 06/11/2013 12:22 PM, Oskar Schirmer wrote:
> >According to documentation bit 3:2 in register SSS_CTRL are
> >reserved and zero, so initially setting the register to 0x0008
> >does not make much sense. Instead, bit 4 should be marked set,
> >as this is the power up default.
> >
> >Further, mask computation in declarative part is obviously wrong:
> >Fix FRAC DIVISOR to provide an 11 bit mask correctly.
> >
> >Signed-off-by: Oskar Schirmer <oskar@scara.com>
> >Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
> Looks good, but please copy Mark Brown. Just added him in Cc now.
Please also use subject lines matching the normal style for the
subsystem. I can't apply this unless someone sends me a copy properly
(not quoted and so on).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-06-12 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 8:12 [PATCH] " Oskar Schirmer
2013-06-11 12:20 ` Fabio Estevam
2013-06-11 15:22 ` [PATCH v2] " Oskar Schirmer
2013-06-11 16:01 ` Fabio Estevam
2013-06-12 16:08 ` Mark Brown [this message]
2013-06-19 13:16 ` [PATCH v3] sound/sgtl5000: fix codec register initial values and handling Oskar Schirmer
2013-06-19 15:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130612160805.GL1403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®