From: Mark Brown <broonie@kernel.org>
To: Oskar Schirmer <oskar@scara.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH v3] sound/sgtl5000: fix codec register initial values and handling
Date: Wed, 19 Jun 2013 16:26:48 +0100 [thread overview]
Message-ID: <20130619152648.GW1403@sirena.org.uk> (raw)
In-Reply-To: <1371647766-4900-1-git-send-email-oskar@scara.com>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On Wed, Jun 19, 2013 at 01:16:06PM +0000, Oskar Schirmer wrote:
This is a set of three unrelated changes, they should be sent as three
separate patches.
> Further, mask computation in declarative part is obviously wrong:
> Fix FRAC DIVISOR to provide an 11 bit mask correctly.
What makes you say that this is obviously wrong? It's not entirely
clear.
> -#define SGTL5000_PLL_FRAC_DIV_MASK 0x0700
> +#define SGTL5000_PLL_FRAC_DIV_MASK 0x07ff
Based on your changelog I was expecting a mask with only two bits set
here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-06-19 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 8:12 [PATCH] sound/sgtl5000: fix codec register initial values and mask Oskar Schirmer
2013-06-11 12:20 ` Fabio Estevam
2013-06-11 15:22 ` [PATCH v2] " Oskar Schirmer
2013-06-11 16:01 ` Fabio Estevam
2013-06-12 16:08 ` Mark Brown
2013-06-19 13:16 ` [PATCH v3] sound/sgtl5000: fix codec register initial values and handling Oskar Schirmer
2013-06-19 15:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130619152648.GW1403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®