mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vince@deater.net>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf: Update perf_event_type documentation
Date: Fri, 26 Jul 2013 10:55:20 +0200	[thread overview]
Message-ID: <20130726085520.GC27075@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1307252320520.26062@pianoman.cluster.toy>

On Thu, Jul 25, 2013 at 11:24:05PM -0400, Vince Weaver wrote:
> On Thu, 25 Jul 2013, Peter Zijlstra wrote:
> 
> > On Thu, Jul 25, 2013 at 08:34:51AM -0400, Vince Weaver wrote:
> > > Yes, I meant the addition of the sample_id fields to the existing sample 
> > > values.  Though if Peter is right and those have always been there since 
> > > the beginning and just not documented then that won't break anything.  
> > > The commit message wasn't really as clear as it could be.
> > 
> > /me writes "I shall write better Changelogs." a hundred times.
> 
> yes, sorry, I shouldn't have been so grumpy about it.

I don't mind; I wish people would tell me my changelogs suck before they
get committed though; I can still fix them at that point.

It not only helps others, but also myself. I've on many occasion kicked
myself for not writing clearer changelogs when investigating something
months (or years) after I wrote the initial code.

The problem is that I mostly know what I mean when I write it and I'm
not very good at writing in the first place -- real changelogs often
take longer to write than the actual code. But I guess that's true for
many people.

Anyway.. I'm ever trying to write better changelogs, but alas there's
also always far more room for improvement :-)

  reply	other threads:[~2013-07-26  8:55 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 13:12 [PATCH V5 00/12] perf tools: some fixes and tweaks Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 01/12] perf tools: add debug prints Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 02/12] perf tools: allow non-matching sample types Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 03/12] perf tools: add pid to struct thread Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 04/12] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 05/12] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 06/12] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 07/12] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 08/12] perf tools: move " Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 09/12] perf: make events stream always parsable Adrian Hunter
2013-07-11 15:43   ` David Ahern
2013-07-11 17:16     ` David Ahern
2013-07-12  6:42     ` Adrian Hunter
2013-07-12  9:56   ` Peter Zijlstra
2013-07-12 12:56     ` Adrian Hunter
2013-07-12 14:55       ` Peter Zijlstra
2013-07-15  6:14         ` Adrian Hunter
2013-07-15 11:53           ` Stephane Eranian
2013-07-15 12:09             ` Adrian Hunter
2013-07-16  6:49           ` Adrian Hunter
2013-07-16 15:09             ` Peter Zijlstra
2013-07-17  4:10               ` Stephane Eranian
2013-07-17 12:44               ` Adrian Hunter
2013-07-24  3:55               ` [tip:perf/core] perf: Update perf_event_type documentation tip-bot for Peter Zijlstra
2013-07-24 17:54                 ` Vince Weaver
2013-07-25  6:22                   ` Adrian Hunter
2013-07-25 12:34                     ` Vince Weaver
2013-07-25 16:27                       ` Peter Zijlstra
2013-07-26  3:24                         ` Vince Weaver
2013-07-26  8:55                           ` Peter Zijlstra [this message]
2013-07-26  3:20                     ` Vince Weaver
2013-07-26  8:57                       ` Peter Zijlstra
2013-07-27  3:20                         ` Vince Weaver
2013-07-25 10:04                   ` Peter Zijlstra
2013-07-25 12:31                     ` Vince Weaver
2013-07-25 12:39                       ` David Ahern
2013-09-13 21:31                 ` Vince Weaver
2013-09-13 21:42                   ` Peter Zijlstra
2013-07-11 13:12 ` [PATCH V5 10/12] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 11/12] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 12/12] perf tools: add a sample parsing test Adrian Hunter
2013-07-16 12:48   ` Jiri Olsa
2013-07-17 11:02     ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130726085520.GC27075@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome