From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vince@deater.net>
Cc: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
adrian.hunter@intel.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf: Update perf_event_type documentation
Date: Fri, 13 Sep 2013 23:42:25 +0200 [thread overview]
Message-ID: <20130913214225.GJ21832@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1309131728260.4174@pianoman.cluster.toy>
On Fri, Sep 13, 2013 at 05:31:26PM -0400, Vince Weaver wrote:
> So in Adrian Hunter's posted patches the PERF_RECORD_MMAP documentation
> is also patched like all the others, with
>
> struct sample_id sample_id;
>
> But in this tip message (and in the current linus-git kernel) somehow the
> PERF_RECORD_MMAP line of the patch was dropped.
>
> Was that intentional?
No, no idea what happened..
---
Subject: perf: Update ABI comment
From: Peter Zijlstra <peterz@infradead.org>
Date: Fri Sep 13 23:39:17 CEST 2013
For some mysterious reason the sample_id field of PERF_RECORD_MMAP
went AWOL.
Reported-by: Vince Weaver <vince@deater.net>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
---
include/uapi/linux/perf_event.h | 1 +
1 file changed, 1 insertion(+)
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -528,6 +528,7 @@ enum perf_event_type {
* u64 len;
* u64 pgoff;
* char filename[];
+ * struct sample_id sample_id;
* };
*/
PERF_RECORD_MMAP = 1,
next prev parent reply other threads:[~2013-09-13 21:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 13:12 [PATCH V5 00/12] perf tools: some fixes and tweaks Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 01/12] perf tools: add debug prints Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 02/12] perf tools: allow non-matching sample types Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 03/12] perf tools: add pid to struct thread Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 04/12] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 05/12] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 06/12] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 07/12] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 08/12] perf tools: move " Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 09/12] perf: make events stream always parsable Adrian Hunter
2013-07-11 15:43 ` David Ahern
2013-07-11 17:16 ` David Ahern
2013-07-12 6:42 ` Adrian Hunter
2013-07-12 9:56 ` Peter Zijlstra
2013-07-12 12:56 ` Adrian Hunter
2013-07-12 14:55 ` Peter Zijlstra
2013-07-15 6:14 ` Adrian Hunter
2013-07-15 11:53 ` Stephane Eranian
2013-07-15 12:09 ` Adrian Hunter
2013-07-16 6:49 ` Adrian Hunter
2013-07-16 15:09 ` Peter Zijlstra
2013-07-17 4:10 ` Stephane Eranian
2013-07-17 12:44 ` Adrian Hunter
2013-07-24 3:55 ` [tip:perf/core] perf: Update perf_event_type documentation tip-bot for Peter Zijlstra
2013-07-24 17:54 ` Vince Weaver
2013-07-25 6:22 ` Adrian Hunter
2013-07-25 12:34 ` Vince Weaver
2013-07-25 16:27 ` Peter Zijlstra
2013-07-26 3:24 ` Vince Weaver
2013-07-26 8:55 ` Peter Zijlstra
2013-07-26 3:20 ` Vince Weaver
2013-07-26 8:57 ` Peter Zijlstra
2013-07-27 3:20 ` Vince Weaver
2013-07-25 10:04 ` Peter Zijlstra
2013-07-25 12:31 ` Vince Weaver
2013-07-25 12:39 ` David Ahern
2013-09-13 21:31 ` Vince Weaver
2013-09-13 21:42 ` Peter Zijlstra [this message]
2013-07-11 13:12 ` [PATCH V5 10/12] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 11/12] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-11 13:12 ` [PATCH V5 12/12] perf tools: add a sample parsing test Adrian Hunter
2013-07-16 12:48 ` Jiri Olsa
2013-07-17 11:02 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913214225.GJ21832@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome