From: "Theodore Ts'o" <tytso@mit.edu>
To: Nitin Singla <nitin.akshainie@gmail.com>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, Manish Sharma <manishrma@gmail.com>,
kapil upadhayay <Kapil.48@gmail.com>
Subject: Re: [PATCH 1/1] EXT4: LazyInit Mount Bug Fix
Date: Sat, 3 Aug 2013 20:49:04 -0400 [thread overview]
Message-ID: <20130804004904.GB19781@thunk.org> (raw)
In-Reply-To: <CAOprVPLa0-xmKE9_vBddR06-RS3WHUGHH5J4pb28L32jHFOFoQ@mail.gmail.com>
On Mon, Jul 15, 2013 at 12:14:18PM +0530, Nitin Singla wrote:
> - sbi->s_itb_per_group = sbi->s_inodes_per_group /
> - sbi->s_inodes_per_block;
> + sbi->s_itb_per_group = DIV_ROUND_UP(sbi->s_inodes_per_group,
> + sbi->s_inodes_per_block);
This would only matter if s_inodes_per_group is not a multiple of
s_inodes_per_block. Which is never supposed to happen; mke2fs doesn't
create file systems like this.
Ancient Android build systems, before the bug was fixed, did do this
in the past, but that was a long time ago. Where did this file system
come from?
I could apply this patch, but you should be warned that there may be
other bugs hiding here for file systems like this, both in the kernel
and in e2fsprogs.
- Ted
parent reply other threads:[~2013-08-04 1:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAOprVPLa0-xmKE9_vBddR06-RS3WHUGHH5J4pb28L32jHFOFoQ@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130804004904.GB19781@thunk.org \
--to=tytso@mit.edu \
--cc=Kapil.48@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishrma@gmail.com \
--cc=nitin.akshainie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®