* Re: [PATCH 1/1] EXT4: LazyInit Mount Bug Fix
[not found] <CAOprVPLa0-xmKE9_vBddR06-RS3WHUGHH5J4pb28L32jHFOFoQ@mail.gmail.com>
@ 2013-08-04 0:49 ` Theodore Ts'o
0 siblings, 0 replies; only message in thread
From: Theodore Ts'o @ 2013-08-04 0:49 UTC (permalink / raw)
To: Nitin Singla
Cc: adilger.kernel, linux-ext4, linux-kernel, Manish Sharma, kapil upadhayay
On Mon, Jul 15, 2013 at 12:14:18PM +0530, Nitin Singla wrote:
> - sbi->s_itb_per_group = sbi->s_inodes_per_group /
> - sbi->s_inodes_per_block;
> + sbi->s_itb_per_group = DIV_ROUND_UP(sbi->s_inodes_per_group,
> + sbi->s_inodes_per_block);
This would only matter if s_inodes_per_group is not a multiple of
s_inodes_per_block. Which is never supposed to happen; mke2fs doesn't
create file systems like this.
Ancient Android build systems, before the bug was fixed, did do this
in the past, but that was a long time ago. Where did this file system
come from?
I could apply this patch, but you should be warned that there may be
other bugs hiding here for file systems like this, both in the kernel
and in e2fsprogs.
- Ted
^ permalink raw reply [flat|nested] only message in thread