From: Mark Brown <broonie@kernel.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Guenter Roeck <linux@roeck-us.net>, Wei Ni <wni@nvidia.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
linux-tegra@vger.kernel.org, MLongnecker@nvidia.com,
khali@linux-fr.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] hwmon: (lm90) Add power control
Date: Thu, 8 Aug 2013 20:27:47 +0100 [thread overview]
Message-ID: <20130808192747.GM6427@sirena.org.uk> (raw)
In-Reply-To: <5203D5B6.3060806@wwwdotorg.org>
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Thu, Aug 08, 2013 at 11:30:30AM -0600, Stephen Warren wrote:
> On 08/08/2013 02:42 AM, Guenter Roeck wrote:
> > If the regulator subsystem is not configured, you especially don't need
> > or want
> > to pollute the log with an error message.
> DT parsing errors should be reported. However, if there's nothing to
> parse, it's not an error.
> So, I think this should report an error message *if* there is a DT
> property that defines the regulator to use. If there's no property, just
> use no regulator. If there is a property, it had better be possible to
> parse it.
On a DT system you should get this behaviour simply by paying attention
to the error code from the regualtor API - the core should complain
loudly if the DT is incomprehensible.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-08 19:28 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 6:56 [PATCH v2 0/3] Add power control for lm90 Wei Ni
2013-08-08 6:56 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-08 7:13 ` Alexander Shiyan
2013-08-08 9:26 ` Wei Ni
2013-08-08 8:42 ` Guenter Roeck
2013-08-08 9:47 ` Wei Ni
2013-08-08 9:57 ` Alexander Shiyan
2013-08-08 9:59 ` Wei Ni
2013-08-08 10:07 ` Wei Ni
2013-08-08 11:23 ` Guenter Roeck
2013-08-08 17:33 ` Stephen Warren
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 18:45 ` Stephen Warren
2013-08-08 17:30 ` Stephen Warren
2013-08-08 17:59 ` Guenter Roeck
2013-08-08 19:27 ` Mark Brown [this message]
2013-08-08 11:01 ` Mark Brown
2013-08-08 11:25 ` Guenter Roeck
2013-08-08 13:08 ` Mark Brown
2013-08-08 15:21 ` Guenter Roeck
2013-08-08 17:15 ` Mark Brown
2013-08-08 20:00 ` Guenter Roeck
2013-08-08 21:18 ` Mark Brown
2013-08-08 21:30 ` Guenter Roeck
2013-08-09 5:57 ` Proposal: I2C device power (Was: hwmon: (lm90) Add power control) Alexander Shiyan
2013-08-09 10:27 ` Mark Brown
2013-08-09 10:50 ` Alexander Shiyan
2013-08-09 11:09 ` Mark Brown
2013-08-09 7:23 ` [PATCH v2 1/3] hwmon: (lm90) Add power control Wei Ni
2013-08-09 10:56 ` Mark Brown
2013-08-08 6:56 ` [PATCH v2 2/3] ARM: dt: t114 dalmore: add dt entry for nct1008 Wei Ni
2013-08-08 17:35 ` Stephen Warren
2013-08-09 6:06 ` Wei Ni
2013-08-08 20:36 ` Sergei Shtylyov
2013-08-08 20:40 ` Stephen Warren
2013-08-08 21:33 ` Guenter Roeck
2013-08-09 6:16 ` Wei Ni
2013-08-08 6:56 ` [PATCH v2 3/3] Documentation: dt: hwmon: add OF document for lm90 Wei Ni
2013-08-08 17:37 ` Stephen Warren
2013-08-09 6:10 ` Wei Ni
2013-08-09 16:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808192747.GM6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=MLongnecker@nvidia.com \
--cc=khali@linux-fr.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®