From: Andi Kleen <ak@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org
Subject: Re: [PATCH 4/6] trace: Make UPROBES depend on PERF_EVENTS
Date: Fri, 4 Oct 2013 20:25:40 -0700 [thread overview]
Message-ID: <20131005032540.GA3363@tassilo.jf.intel.com> (raw)
In-Reply-To: <20131004205253.64dc04c9@gandalf.local.home>
On Fri, Oct 04, 2013 at 08:52:53PM -0400, Steven Rostedt wrote:
> On Fri, 4 Oct 2013 14:39:46 -0700
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > UPROBES need the perf events code, so add a dependency
> > from PERF_EVENTS to UPROBES.
>
> Can you please be a bit more specific on what uprobes requires of perf?
> That is, what part of the perf events code is needed, and why?
Without this dependency, when UPROBE_EVENT is enabled and PERF_EVENTS disabled
I first get
warning: (UPROBE_EVENT) selects UPROBES which has unmet direct dependencies (UPROBE_EVENT && PERF_EVENTS)
warning: (UPROBE_EVENT) selects UPROBES which has unmet direct dependencies (UPROBE_EVENT && PERF_EVENTS)
and then later lots of errors like
arch/x86/built-in.o: In function `do_notify_resume':
/home/ak/lsrc/git/linux-2.6/arch/x86/kernel/signal.c:743: undefined reference to `uprobe_notify_resume'
arch/x86/built-in.o: In function `arch_uprobe_exception_notify':
/home/ak/lsrc/git/linux-2.6/arch/x86/kernel/uprobes.c:637: undefined reference to `uprobe_pre_sstep_notifier'
/home/ak/lsrc/git/linux-2.6/arch/x86/kernel/uprobes.c:643: undefined reference to `uprobe_post_sstep_notifier'
kernel/built-in.o: In function `mmput':
/home/ak/lsrc/git/linux-2.6/kernel/fork.c:608: undefined reference to `uprobe_clear_state'
I'm not fully sure why UPROBES has the && PERF_EVENTS; I didn't add that.
-Andi
next prev parent reply other threads:[~2013-10-05 3:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 21:39 Allow disabling perf on x86 Andi Kleen
2013-10-04 21:39 ` [PATCH 1/6] perf, x86, amd: Move __get_ibs_caps into common amd CPU file Andi Kleen
2013-10-04 21:39 ` [PATCH 2/6] perf, x86: Make perf amd ibs code depend on PERF_EVENTS and SUP_AMD Andi Kleen
2013-10-04 21:39 ` [PATCH 3/6] x86, ptrace: Ifdef HW_BREAKPOINTS code in ptrace Andi Kleen
2013-10-04 21:39 ` [PATCH 4/6] trace: Make UPROBES depend on PERF_EVENTS Andi Kleen
2013-10-05 0:52 ` Steven Rostedt
2013-10-05 3:25 ` Andi Kleen [this message]
2013-10-04 21:39 ` [PATCH 5/6] x86, kgdb: Support compiling without hardware break points Andi Kleen
2013-10-04 21:39 ` [PATCH 6/6] x86: Allow disabling HW_BREAKPOINTS and PERF_EVENTS Andi Kleen
2013-10-04 22:27 ` Frederic Weisbecker
2013-10-05 7:08 ` Ingo Molnar
2013-10-05 17:05 ` Andi Kleen
2013-10-08 19:55 ` Frederic Weisbecker
2013-10-08 20:05 ` Peter Zijlstra
2013-10-08 20:34 ` Frederic Weisbecker
2013-10-08 20:35 ` Frederic Weisbecker
2013-10-09 6:02 ` Ingo Molnar
2013-10-06 16:49 ` Ingo Molnar
2013-10-08 6:59 ` Ingo Molnar
2013-10-08 15:35 ` Steven Rostedt
2013-10-08 19:39 ` Ingo Molnar
2013-10-08 15:42 ` Vince Weaver
2013-10-08 15:51 ` Dave Jones
2013-10-08 16:22 ` David Ahern
2013-10-08 16:24 ` Dave Jones
2013-10-08 19:36 ` Ingo Molnar
2013-10-08 20:19 ` Steven Rostedt
2013-10-09 3:21 ` Andi Kleen
2013-10-09 3:24 ` Andi Kleen
2013-10-09 3:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131005032540.GA3363@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome