From: Mark Brown <broonie@kernel.org>
To: Wei Ni <wni@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints
Date: Sat, 12 Oct 2013 13:14:12 +0100 [thread overview]
Message-ID: <20131012121412.GJ2443@sirena.org.uk> (raw)
In-Reply-To: <5253D489.7010900@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 563 bytes --]
On Tue, Oct 08, 2013 at 05:46:49PM +0800, Wei Ni wrote:
> In the regulator_dev_lookup(), it will try to read the "xx-supply" to
> get the regnode, but I didn't set the vcc-supply in dts file for lm90,
> so the of_get_regulator() will return NULL, then the
> regulator_dev_lookup() will set the ret to -ENODEV, and return the rdev
> as NULL.
OK, I think the device tree board code just needs to set full
constraints during machine initialisation. We can't have multiple
initcalls in the regulator code and doing it there is really a bit of a
workaround anyway.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-12 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 6:09 Wei Ni
2013-10-08 9:09 ` Mark Brown
2013-10-08 9:46 ` Wei Ni
2013-10-12 12:14 ` Mark Brown [this message]
2013-10-16 4:36 ` Wei Ni
2013-10-16 10:39 ` Mark Brown
2013-10-17 4:39 ` Wei Ni
2013-10-17 9:37 ` Mark Brown
2013-10-17 10:39 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012121412.GJ2443@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®