From: Wei Ni <wni@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: About [PATCH 1/2] regulator: core: Provide a dummy regulator with full constraints
Date: Wed, 16 Oct 2013 12:36:46 +0800 [thread overview]
Message-ID: <525E17DE.6080301@nvidia.com> (raw)
In-Reply-To: <20131012121412.GJ2443@sirena.org.uk>
On 10/12/2013 08:14 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Oct 08, 2013 at 05:46:49PM +0800, Wei Ni wrote:
>
>> In the regulator_dev_lookup(), it will try to read the "xx-supply" to
>> get the regnode, but I didn't set the vcc-supply in dts file for lm90,
>> so the of_get_regulator() will return NULL, then the
>> regulator_dev_lookup() will set the ret to -ENODEV, and return the rdev
>> as NULL.
>
> OK, I think the device tree board code just needs to set full
> constraints during machine initialisation. We can't have multiple
Hi, Mark, do you mean we can call regulator_has_full_constraints(), but
some platforms doesn't have board file now, they only have dts file, how
to call this functions?
Wei.
> initcalls in the regulator code and doing it there is really a bit of a
> workaround anyway.
>
> * Unknown Key
> * 0x7EA229BD
>
next prev parent reply other threads:[~2013-10-16 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 6:09 Wei Ni
2013-10-08 9:09 ` Mark Brown
2013-10-08 9:46 ` Wei Ni
2013-10-12 12:14 ` Mark Brown
2013-10-16 4:36 ` Wei Ni [this message]
2013-10-16 10:39 ` Mark Brown
2013-10-17 4:39 ` Wei Ni
2013-10-17 9:37 ` Mark Brown
2013-10-17 10:39 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525E17DE.6080301@nvidia.com \
--to=wni@nvidia.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome