mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Lee Jones <lee.jones@linaro.org>, Simon <horms@verge.net.au>,
	Magnus <magnus.damm@gmail.com>,
	Linux-SH <linux-sh@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: About gpio-regulator setting on DT
Date: Wed, 29 Jan 2014 12:45:16 +0000	[thread overview]
Message-ID: <20140129124516.GZ11841@sirena.org.uk> (raw)
In-Reply-To: <87r47r6v48.wl%kuninori.morimoto.gx@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Wed, Jan 29, 2014 at 12:38:19AM -0800, Kuninori Morimoto wrote:

> How to set GPIOF_OUT_INIT_HIGH via DT ?
> Or, am I misunderstanding ?

The combination of the enable-active-high and enable-at-boot properties
ought be able to cause the driver to do the right thing, the flags do
this:

	if (config->enabled_at_boot) {
		if (config->enable_high)
			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_HIGH;
		else
			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_LOW;
	} else {
		if (config->enable_high)
			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_LOW;
		else
			cfg.ena_gpio_flags |= GPIOF_OUT_INIT_HIGH;
	}

of_get_named_gpio() just looks up the GPIO number, it doesn't request
the GPIO.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-01-29 12:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29  8:38 Kuninori Morimoto
2014-01-29 12:45 ` Mark Brown [this message]
2014-01-29 16:16   ` Ben Dooks
2014-01-29 16:51     ` Mark Brown
2014-01-30  0:08   ` Kuninori Morimoto
2014-01-30 12:12     ` Mark Brown
2014-01-31  5:25       ` [PATCH] regulator: gpio: bugfix: add gpios-status for DT Kuninori Morimoto
2014-02-04 18:43         ` Mark Brown
2014-02-12  1:27           ` [PATCH 1/2] regulator: gpio: print warning if gpios <-> gpios-states mismatch on DT Kuninori Morimoto
2014-02-12 12:01             ` Mark Brown
2014-02-12  1:27           ` [PATCH 2/2] regulator: gpio: explain detail of gpios-states Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140129124516.GZ11841@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®