From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Lee Jones <lee.jones@linaro.org>, Simon <horms@verge.net.au>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: About gpio-regulator setting on DT
Date: Thu, 30 Jan 2014 12:12:51 +0000 [thread overview]
Message-ID: <20140130121251.GO22609@sirena.org.uk> (raw)
In-Reply-To: <87mwieib5x.wl%kuninori.morimoto.gx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Wed, Jan 29, 2014 at 04:08:30PM -0800, Kuninori Morimoto wrote:
> /* build initial state from gpio init data. */
> state = 0;
> for (ptr = 0; ptr < drvdata->nr_gpios; ptr++) {
> if (config->gpios[ptr].flags & GPIOF_OUT_INIT_HIGH) <== we need this
> state |= (1 << ptr);
> }
> drvdata->state = state;
So this just looks like a bug in the code - the DT has all the data
needed but the parsing code isn't setting everything up that the rest of
the code needs and/or we should drop one of the ways of configuring
things in the main probe function. Avoiding having two ways of doing
the same thing in the main probe would definitely be good.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-30 12:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 8:38 Kuninori Morimoto
2014-01-29 12:45 ` Mark Brown
2014-01-29 16:16 ` Ben Dooks
2014-01-29 16:51 ` Mark Brown
2014-01-30 0:08 ` Kuninori Morimoto
2014-01-30 12:12 ` Mark Brown [this message]
2014-01-31 5:25 ` [PATCH] regulator: gpio: bugfix: add gpios-status for DT Kuninori Morimoto
2014-02-04 18:43 ` Mark Brown
2014-02-12 1:27 ` [PATCH 1/2] regulator: gpio: print warning if gpios <-> gpios-states mismatch on DT Kuninori Morimoto
2014-02-12 12:01 ` Mark Brown
2014-02-12 1:27 ` [PATCH 2/2] regulator: gpio: explain detail of gpios-states Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130121251.GO22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®