From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Lee Jones <lee.jones@linaro.org>, Simon <horms@verge.net.au>,
Magnus <magnus.damm@gmail.com>,
Linux-SH <linux-sh@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: gpio: bugfix: add gpios-status for DT
Date: Tue, 4 Feb 2014 18:43:27 +0000 [thread overview]
Message-ID: <20140204184327.GS22609@sirena.org.uk> (raw)
In-Reply-To: <87eh3o7mfc.wl%kuninori.morimoto.gx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
On Thu, Jan 30, 2014 at 09:25:14PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> config->gpios[x].flags indicates initial pin status,
> and it will be used for drvdata->state
> on gpio_regulator_probe().
I've applied this, thanks. However, a couple of things that it'd be
nice to improve with followup patches:
> +- gpios-states : gpios pin's initial states. 1 means HIGH
A mention that this is an array of values would be good (it's clear from
the code but not from the document), as would saying that the defualt is
low if nothing is specified.
> + if (proplen != config->nr_gpios) {
> + /* gpios <-> gpios-states mismatch */
> + prop = NULL;
> + }
> + }
It's probably worth printing a warning here.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-04 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 8:38 About gpio-regulator setting on DT Kuninori Morimoto
2014-01-29 12:45 ` Mark Brown
2014-01-29 16:16 ` Ben Dooks
2014-01-29 16:51 ` Mark Brown
2014-01-30 0:08 ` Kuninori Morimoto
2014-01-30 12:12 ` Mark Brown
2014-01-31 5:25 ` [PATCH] regulator: gpio: bugfix: add gpios-status for DT Kuninori Morimoto
2014-02-04 18:43 ` Mark Brown [this message]
2014-02-12 1:27 ` [PATCH 1/2] regulator: gpio: print warning if gpios <-> gpios-states mismatch on DT Kuninori Morimoto
2014-02-12 12:01 ` Mark Brown
2014-02-12 1:27 ` [PATCH 2/2] regulator: gpio: explain detail of gpios-states Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204184327.GS22609@sirena.org.uk \
--to=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome