mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Hao <haokexin@gmail.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 4/4] of: Add self test for of_match_node()
Date: Wed, 19 Feb 2014 14:31:31 +0800	[thread overview]
Message-ID: <20140219063130.GC14031@pek-khao-d1.corp.ad.wrs.com> (raw)
In-Reply-To: <1392762680-1498-5-git-send-email-grant.likely@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

On Tue, Feb 18, 2014 at 10:31:20PM +0000, Grant Likely wrote:
> Adds a selftest function for the of_match_node function. of_match_node
> is supposed to handle precedence for the compatible property as well as
> the name and device_type values. This patch adds some test case data and
> a function that makes sure each test node matches against the correct
> entry of an of_device_id table.
> 
> This code was written to verify the new of_match_node() implementation
> that is an earlier part of this series.
> 
> Currently all but one test passes. There is one scenario where the empty
> "b/name2" node is getting matched against an entry without any
> device_type property at all. It is unknown why this is, but it needs to
> be solved before this patch can be committed. (However, this is testing
> the new of_match_table implementation, which still does far better than
> the old implementation which gets the precedence completely wrong.)

We can drop the above paragraph now since all the test cases passed on
the new version of of_match_node().

> 
> Signed-off-by: Grant Likely <grant.likely@linaro.org>
> Cc: Kevin Hau <haokexin@gmail.com>

s/Hau/Hao/

Thanks,
Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

      reply	other threads:[~2014-02-19  6:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 22:31 Bug fix and test matching method " Grant Likely
2014-02-18 22:31 ` [PATCH 1/4] Revert "of: search the best compatible match first in __of_match_node()" Grant Likely
2014-02-18 22:31 ` [PATCH 2/4] of: reimplement the matching method for __of_match_node() Grant Likely
2014-02-19  6:21   ` [PATCH v2 " Kevin Hao
2014-02-19  7:58     ` Kevin Hao
2014-02-19  8:15       ` [PATCH v3 " Kevin Hao
2014-02-19 12:48         ` Grant Likely
2014-02-19 12:57         ` Grant Likely
2014-02-18 22:31 ` [PATCH 3/4] of: Move testcase FDT data into drivers/of Grant Likely
2014-02-18 22:31 ` [PATCH 4/4] of: Add self test for of_match_node() Grant Likely
2014-02-19  6:31   ` Kevin Hao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140219063130.GC14031@pek-khao-d1.corp.ad.wrs.com \
    --to=haokexin@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®