From: Kevin Hao <haokexin@gmail.com>
To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v2 2/4] of: reimplement the matching method for __of_match_node()
Date: Wed, 19 Feb 2014 15:58:12 +0800 [thread overview]
Message-ID: <20140219075812.GE14031@pek-khao-d1.corp.ad.wrs.com> (raw)
In-Reply-To: <1392790862-18025-1-git-send-email-haokexin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Wed, Feb 19, 2014 at 02:21:02PM +0800, Kevin Hao wrote:
> + /*
> + * Matching compatible is better than matching type and name,
> + * and the specific compatible is better than the general.
> + */
> + if (matches->compatible[0] &&
> + __of_device_is_compatible_score(node,
> + matches->compatible, &score))
> + score = INT_MAX - 4 * score;
It seems that we also need to adjust the above as what we do for the type
and name. The v3 is coming.
Thanks,
Kevin
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-02-19 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:31 Bug fix and test matching method for of_match_node() Grant Likely
2014-02-18 22:31 ` [PATCH 1/4] Revert "of: search the best compatible match first in __of_match_node()" Grant Likely
2014-02-18 22:31 ` [PATCH 2/4] of: reimplement the matching method for __of_match_node() Grant Likely
2014-02-19 6:21 ` [PATCH v2 " Kevin Hao
2014-02-19 7:58 ` Kevin Hao [this message]
2014-02-19 8:15 ` [PATCH v3 " Kevin Hao
2014-02-19 12:48 ` Grant Likely
2014-02-19 12:57 ` Grant Likely
2014-02-18 22:31 ` [PATCH 3/4] of: Move testcase FDT data into drivers/of Grant Likely
2014-02-18 22:31 ` [PATCH 4/4] of: Add self test for of_match_node() Grant Likely
2014-02-19 6:31 ` Kevin Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219075812.GE14031@pek-khao-d1.corp.ad.wrs.com \
--to=haokexin@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®