* [PATCH] ioat: Use pci_enable_msix_range() instead of pci_enable_msix()
@ 2014-02-19 10:15 Alexander Gordeev
2014-02-21 16:21 ` [PATCH v2] ioat: Use pci_enable_msix_exact() " Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2014-02-19 10:15 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Gordeev, Dan Williams, Vinod Koul, dmaengine, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
drivers/dma/ioat/dma.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 8752918..af0d8b1 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -909,8 +909,9 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;
- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
- if (err)
+ err = pci_enable_msix_range(pdev,
+ device->msix_entries, msixcnt, msixcnt);
+ if (err < 0)
goto msi;
for (i = 0; i < msixcnt; i++) {
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-02-19 10:15 [PATCH] ioat: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
@ 2014-02-21 16:21 ` Alexander Gordeev
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-02-21 16:21 UTC (permalink / raw)
To: linux-kernel; +Cc: Dan Williams, Vinod Koul, dmaengine, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
drivers/dma/ioat/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 8752918..7bc9e6f 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -909,7 +909,7 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;
- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
+ err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
if (err)
goto msi;
--
1.7.7.6
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 0/4] : Use pci_enable_msix_exact() instead of pci_enable_msix()
@ 2014-03-06 20:11 Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 1/4] ioat: " Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2014-03-06 20:11 UTC (permalink / raw)
To: linux-kernel; +Cc: Alexander Gordeev
The series is based on 3.14-rc4.
The patches are unrelated to each other.
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Alexander Gordeev (4):
ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
portdrv: Use pci_enable_msix_exact() instead of pci_enable_msix()
tsi721: Use pci_enable_msix_exact() instead of pci_enable_msix()
xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()
drivers/dma/ioat/dma.c | 2 +-
drivers/pci/pcie/portdrv_core.c | 4 ++--
drivers/rapidio/devices/tsi721.c | 11 +++--------
drivers/usb/host/xhci.c | 7 ++++---
4 files changed, 10 insertions(+), 14 deletions(-)
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-06 20:11 [PATCH v2 RESEND 0/4] : " Alexander Gordeev
@ 2014-03-06 20:11 ` Alexander Gordeev
2014-03-06 21:09 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2014-03-06 20:11 UTC (permalink / raw)
To: linux-kernel
Cc: Alexander Gordeev, Dan Williams, Vinod Koul, dmaengine, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
drivers/dma/ioat/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 4e3549a..b76c148 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -947,7 +947,7 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;
- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
+ err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
if (err)
goto msi;
--
1.7.7.6
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-06 20:11 ` [PATCH v2 RESEND 1/4] ioat: " Alexander Gordeev
@ 2014-03-06 21:09 ` Dan Williams
2014-03-06 21:43 ` Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2014-03-06 21:09 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
On Thu, Mar 6, 2014 at 12:11 PM, Alexander Gordeev <agordeev@redhat.com> wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> ---
Can you point me to the background for this change. From the
changelog I have no idea what this patch does or why I need to apply
it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-06 21:09 ` Dan Williams
@ 2014-03-06 21:43 ` Alexander Gordeev
2014-03-06 21:50 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2014-03-06 21:43 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
On Thu, Mar 06, 2014 at 01:09:39PM -0800, Dan Williams wrote:
> Can you point me to the background for this change. From the
> changelog I have no idea what this patch does or why I need to apply
> it.
Function pci_enable_msix() returns a tri-state value while
pci_enable_msi_exact() is a canonical zero/-errno variant.
The former is being phased out in favor of the latter.
In case of 'ioat' there (should be) no difference.
HTH.
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 RESEND 1/4] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-06 21:43 ` Alexander Gordeev
@ 2014-03-06 21:50 ` Dan Williams
2014-03-07 7:49 ` [PATCH v2] " Alexander Gordeev
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2014-03-06 21:50 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
On Thu, Mar 6, 2014 at 1:43 PM, Alexander Gordeev <agordeev@redhat.com> wrote:
> On Thu, Mar 06, 2014 at 01:09:39PM -0800, Dan Williams wrote:
>> Can you point me to the background for this change. From the
>> changelog I have no idea what this patch does or why I need to apply
>> it.
>
> Function pci_enable_msix() returns a tri-state value while
> pci_enable_msi_exact() is a canonical zero/-errno variant.
> The former is being phased out in favor of the latter.
> In case of 'ioat' there (should be) no difference.
Got it. If you resend with that in the changelog.
Acked-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-06 21:50 ` Dan Williams
@ 2014-03-07 7:49 ` Alexander Gordeev
2014-04-21 13:36 ` Alexander Gordeev
2014-08-25 16:35 ` Alexander Gordeev
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-03-07 7:49 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.
Function pci_enable_msix() returns a tri-state value while
pci_enable_msi_exact() is a canonical zero/-errno variant.
The former is being phased out in favor of the latter.
In case of 'ioat' there (should be) no difference.
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Acked-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/dma/ioat/dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 4e3549a..b76c148 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -947,7 +947,7 @@ msix:
for (i = 0; i < msixcnt; i++)
device->msix_entries[i].entry = i;
- err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
+ err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
if (err)
goto msi;
--
1.7.7.6
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-07 7:49 ` [PATCH v2] " Alexander Gordeev
@ 2014-04-21 13:36 ` Alexander Gordeev
2014-08-25 16:35 ` Alexander Gordeev
1 sibling, 0 replies; 6+ messages in thread
From: Alexander Gordeev @ 2014-04-21 13:36 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Function pci_enable_msix() returns a tri-state value while
> pci_enable_msi_exact() is a canonical zero/-errno variant.
> The former is being phased out in favor of the latter.
> In case of 'ioat' there (should be) no difference.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Acked-by: Dan Williams <dan.j.williams@intel.com>
Hi Dan,
Would you pick this patch, please?
Thanks!
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-03-07 7:49 ` [PATCH v2] " Alexander Gordeev
2014-04-21 13:36 ` Alexander Gordeev
@ 2014-08-25 16:35 ` Alexander Gordeev
2014-08-25 16:31 ` Dan Williams
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Gordeev @ 2014-08-25 16:35 UTC (permalink / raw)
To: Dan Williams, Vinod Koul; +Cc: linux-kernel, Vinod Koul, dmaengine, linux-pci
On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
Dan, Vinod,
This patch hangs in -next for quite some time.
Would you release it, please?
Thanks!
> Function pci_enable_msix() returns a tri-state value while
> pci_enable_msi_exact() is a canonical zero/-errno variant.
> The former is being phased out in favor of the latter.
> In case of 'ioat' there (should be) no difference.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: linux-pci@vger.kernel.org
> Acked-by: Dan Williams <dan.j.williams@intel.com>
> ---
> drivers/dma/ioat/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index 4e3549a..b76c148 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -947,7 +947,7 @@ msix:
> for (i = 0; i < msixcnt; i++)
> device->msix_entries[i].entry = i;
>
> - err = pci_enable_msix(pdev, device->msix_entries, msixcnt);
> + err = pci_enable_msix_exact(pdev, device->msix_entries, msixcnt);
> if (err)
> goto msi;
>
> --
> 1.7.7.6
>
> --
> Regards,
> Alexander Gordeev
> agordeev@redhat.com
--
Regards,
Alexander Gordeev
agordeev@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ioat: Use pci_enable_msix_exact() instead of pci_enable_msix()
2014-08-25 16:35 ` Alexander Gordeev
@ 2014-08-25 16:31 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2014-08-25 16:31 UTC (permalink / raw)
To: Alexander Gordeev; +Cc: Vinod Koul, linux-kernel, dmaengine, linux-pci
On Mon, Aug 25, 2014 at 9:35 AM, Alexander Gordeev <agordeev@redhat.com> wrote:
> On Fri, Mar 07, 2014 at 08:49:32AM +0100, Alexander Gordeev wrote:
>> As result of deprecation of MSI-X/MSI enablement functions
>> pci_enable_msix() and pci_enable_msi_block() all drivers
>> using these two interfaces need to be updated to use the
>> new pci_enable_msi_range() or pci_enable_msi_exact()
>> and pci_enable_msix_range() or pci_enable_msix_exact()
>> interfaces.
>
> Dan, Vinod,
>
> This patch hangs in -next for quite some time.
> Would you release it, please?
On its way... apologies for the delay.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-25 16:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-19 10:15 [PATCH] ioat: Use pci_enable_msix_range() instead of pci_enable_msix() Alexander Gordeev
2014-02-21 16:21 ` [PATCH v2] ioat: Use pci_enable_msix_exact() " Alexander Gordeev
2014-03-06 20:11 [PATCH v2 RESEND 0/4] : " Alexander Gordeev
2014-03-06 20:11 ` [PATCH v2 RESEND 1/4] ioat: " Alexander Gordeev
2014-03-06 21:09 ` Dan Williams
2014-03-06 21:43 ` Alexander Gordeev
2014-03-06 21:50 ` Dan Williams
2014-03-07 7:49 ` [PATCH v2] " Alexander Gordeev
2014-04-21 13:36 ` Alexander Gordeev
2014-08-25 16:35 ` Alexander Gordeev
2014-08-25 16:31 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®