* [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style
@ 2014-03-16 19:18 Daniel Ngu
2014-03-16 19:21 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ngu @ 2014-03-16 19:18 UTC (permalink / raw)
To: Jonathan Kim; +Cc: Dean ahn, devel, linux-kernel
Missing space after return type
Signed-off-by: Daniel Ngu <daniel.dy.ngu@gmail.com>
---
drivers/staging/gdm724x/gdm_lte.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
index 9287d31..88414e5 100644
--- a/drivers/staging/gdm724x/gdm_lte.h
+++ b/drivers/staging/gdm724x/gdm_lte.h
@@ -56,7 +56,7 @@ struct phy_dev {
int (*cb)(void *cb_data, void *data, int len,
int context),
void *cb_data, int context);
- struct gdm_endian *(*get_endian)(void *priv_dev);
+ struct gdm_endian * (*get_endian)(void *priv_dev);
};
struct nic {
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style
2014-03-16 19:18 [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style Daniel Ngu
@ 2014-03-16 19:21 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-03-16 19:21 UTC (permalink / raw)
To: Daniel Ngu; +Cc: Jonathan Kim, Dean ahn, devel, linux-kernel
On Mon, 2014-03-17 at 08:18 +1300, Daniel Ngu wrote:
> Missing space after return type
Not really.
> diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
[]
> @@ -56,7 +56,7 @@ struct phy_dev {
> int (*cb)(void *cb_data, void *data, int len,
> int context),
> void *cb_data, int context);
> - struct gdm_endian *(*get_endian)(void *priv_dev);
> + struct gdm_endian * (*get_endian)(void *priv_dev);
That one was a defect in checkpatch that was
corrected in -next by:
commit 93ca9441419b0bfbf96243e01f39b5a80565215e
Author: Joe Perches <joe@perches.com>
Date: Thu Mar 6 11:02:08 2014 +1100
checkpatch: don't warn on some function pointer return styles
Checks for some function pointer return styles are too strict. Fix them.
Multiple spaces after function pointer return types are allowed.
int (*foo)(int bar)
Spaces after function pointer returns of pointer types are not required.
int *(*foo)(int bar)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-16 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-16 19:18 [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style Daniel Ngu
2014-03-16 19:21 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®