mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Laura Abbott <lauraa@codeaurora.org>
Cc: "Kees Cook" <keescook@chromium.org>,
	"Catalin Marinas" <Catalin.Marinas@arm.com>,
	"Will Deacon" <Will.Deacon@arm.com>,
	"Larry Bassel" <lbassel@codeaurora.org>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Nicolas Pitre" <nico@linaro.org>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	"Jiang Liu" <liuj97@gmail.com>,
	"Christoffer Dall" <cdall@cs.columbia.edu>,
	"Marc Zyngier" <Marc.Zyngier@arm.com>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"Vitaly Andrianov" <vitalya@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"Simon Baatz" <gmbnomis@gmail.com>,
	"Jonathan Austin" <Jonathan.Austin@arm.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] ARM: mm: keep rodata non-executable
Date: Mon, 24 Mar 2014 12:30:08 +0000	[thread overview]
Message-ID: <20140324123008.GB3669@e103592.cambridge.arm.com> (raw)
In-Reply-To: <532F2C48.6050509@codeaurora.org>

On Sun, Mar 23, 2014 at 06:47:36PM +0000, Laura Abbott wrote:
> On 2/17/2014 4:34 AM, Dave Martin wrote:
> > On Fri, Feb 14, 2014 at 11:11:07AM -0800, Kees Cook wrote:
> >> On Fri, Feb 14, 2014 at 8:22 AM, Dave Martin <Dave.Martin@arm.com> wrote:
> >>> On Thu, Feb 13, 2014 at 05:04:10PM -0800, Kees Cook wrote:
> >>>> Introduce "CONFIG_DEBUG_RODATA" to mostly match the x86 config, though
> >>>> the behavior is different: it depends on STRICT_KERNMEM_PERMS, which
> >>>> sets rodata read-only (but executable), where as this option additionally
> >>>> splits rodata from the kernel text (resulting in potentially more memory
> >>>> lost to padding) and sets it non-executable as well. The end result is
> >>>> that on builds with CONFIG_DEBUG_RODATA=y (like x86) the rodata with be
> >>>> marked purely read-only.
> >>>
> >>> This triggers an Oops in kexec, because we have a block of code in .text
> >>> which is a template for generating baremetal code to relocate the new
> >>> kernel, and some literal words are written into it before copying.
> >>
> >> You're writing into the text area? I would imagine that
> >> CONFIG_ARM_KERNMEM_PERMS would break that. However, that's not the
> >> right place to be building code -- shouldn't the module area be used
> >> for that?
> >>

[...]
	
> FWIW, we've hit issues not just with kexec but kprobes as well. The same
> problems exist with this series:

[...]

> We had some functions that allowed the text to be temporarily made writable but something
> uniform for kexec would be useful as well (our kexec solution has been 'turn it off')

kexec doesn't rely on poking the kernel text: the fact that it does this
is just a side-effect of the way it is currently implemented.

I would like to fix it -- it's currently on my todo list, but I
consider it non-urgent.  depending on !KEXEC seems reasonable for
now.

People building a hardened system may choose do disable kexec for other
reasons, but that's a separate issue entirely.


kprobes is a different matter: getting it to work with strict permissions
is likely to be complex and costly.  kprobes is already unavoidably
complex and costly, so that is probably better viewed as a kprobes
problem to be solved later, rather than a strict permissions problem.


Cheers
---Dave

      parent reply	other threads:[~2014-03-24 12:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-14  1:04 [PATCH 0/2] ARM: mm: allow for stricter kernel memory perms Kees Cook
2014-02-14  1:04 ` [PATCH 1/2] " Kees Cook
2014-02-14  1:04 ` [PATCH 2/2] ARM: mm: keep rodata non-executable Kees Cook
2014-02-14 16:22   ` Dave Martin
2014-02-14 19:11     ` Kees Cook
2014-02-17 12:34       ` Dave Martin
2014-02-18 18:10         ` Kees Cook
2014-02-21 12:37           ` Dave Martin
2014-02-21 13:20             ` Russell King - ARM Linux
2014-02-21 22:09               ` Kees Cook
2014-03-13 19:07                 ` Kees Cook
2014-03-23 18:32                   ` Laura Abbott
2014-03-23 22:20                     ` Kees Cook
2014-03-23 18:47         ` Laura Abbott
2014-03-23 22:21           ` Kees Cook
2014-03-23 22:37             ` Nicolas Pitre
2014-03-23 22:56               ` Kees Cook
2014-03-24 10:47             ` Jon Medhurst (Tixy)
2014-04-01 22:34               ` Kees Cook
2014-04-01 22:54                 ` Laura Abbott
2014-04-01 22:59                   ` Kees Cook
2014-03-24 12:30           ` Dave Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140324123008.GB3669@e103592.cambridge.arm.com \
    --to=dave.martin@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Jonathan.Austin@arm.com \
    --cc=Marc.Zyngier@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=cdall@cs.columbia.edu \
    --cc=gmbnomis@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=lauraa@codeaurora.org \
    --cc=lbassel@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liuj97@gmail.com \
    --cc=nico@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=santosh.shilimkar@ti.com \
    --cc=sfr@canb.auug.org.au \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vitalya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®