From: Steven Rostedt <rostedt@goodmis.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Matthew Whitehead <tedheadster@gmail.com>,
John Stultz <john.stultz@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
mwhitehe@redhat.com
Subject: Re: nohz problem with idle time on old hardware
Date: Wed, 9 Apr 2014 11:29:50 -0400 [thread overview]
Message-ID: <20140409112950.7be9f8ac@gandalf.local.home> (raw)
In-Reply-To: <CAKohponY+4y8G875wy4GsO1hTqERc7-hYKY6uQvLn28+32VxVQ@mail.gmail.com>
On Wed, 9 Apr 2014 20:50:59 +0530
Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 9 April 2014 20:01, Steven Rostedt <rostedt@goodmis.org> wrote:
> > Ouch! You are correct, this part of the patch makes no sense. That's
> > what I get for reviewing a patch and not looking at all the code around
> > the changes. (another kernel developer hangs head in shame :-( )
> >
> > I think that if statement should be nuked.
>
> Hmm, my opinion differs here :)
>
> If we completely remove this statement, we will run
> tick_nohz_switch_to_nohz() even if nohz is not enabled. And check for
> enabled must stay.
Do we? This is only called by tick_check_oneshot_change() which has the
following:
int tick_check_oneshot_change(int allow_nohz)
{
struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
if (!test_and_clear_bit(0, &ts->check_clocks))
return 0;
if (ts->nohz_mode != NOHZ_MODE_INACTIVE)
return 0;
if (!timekeeping_valid_for_hres() || !tick_is_oneshot_available())
return 0;
if (!allow_nohz)
return 1;
tick_nohz_switch_to_nohz();
return 0;
}
How often does it make it to that last check?
-- Steve
next prev parent reply other threads:[~2014-04-09 15:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 11:39 Matthew Whitehead
2013-11-13 14:02 ` Thomas Gleixner
2013-11-13 15:21 ` Steven Rostedt
2013-11-13 15:31 ` Steven Rostedt
2013-11-13 15:50 ` Thomas Gleixner
2013-11-13 16:17 ` Paul E. McKenney
2013-11-13 15:57 ` Steven Rostedt
2013-11-13 16:07 ` Thomas Gleixner
2013-11-13 16:12 ` Steven Rostedt
2013-11-13 16:18 ` Paul E. McKenney
2013-11-13 16:23 ` Steven Rostedt
2013-11-13 16:35 ` Paul E. McKenney
2013-11-13 20:01 ` Thomas Gleixner
2013-11-13 20:07 ` Steven Rostedt
2013-11-13 21:49 ` Matthew Whitehead
2013-11-18 22:44 ` Paul E. McKenney
2013-11-19 18:07 ` [tip:timers/urgent] NOHZ: Check for nohz active instead of nohz enabled tip-bot for Thomas Gleixner
2014-04-09 13:51 ` nohz problem with idle time on old hardware Viresh Kumar
2014-04-09 14:31 ` Steven Rostedt
2014-04-09 15:20 ` Viresh Kumar
2014-04-09 15:29 ` Steven Rostedt [this message]
2014-04-09 15:31 ` Steven Rostedt
2014-04-09 15:34 ` Viresh Kumar
2014-04-09 15:39 ` Steven Rostedt
2014-04-09 15:56 ` Viresh Kumar
2014-04-09 16:15 ` Steven Rostedt
2014-04-09 15:11 ` Frederic Weisbecker
2013-11-13 16:21 ` Thomas Gleixner
2013-11-13 16:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409112950.7be9f8ac@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwhitehe@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tedheadster@gmail.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®