From: Felipe Balbi <balbi@ti.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: <linux-kernel@vger.kernel.org>, <myungjoo.ham@samsung.com>,
<balbi@ti.com>, <gg@slimlogic.co.uk>, <kishon@ti.com>,
<ckeepax@opensource.wolfsonmicro.com>, <broonie@kernel.org>,
<k.kozlowski@samsung.com>, <kyungmin.park@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCHv3 9/9] extcon: palmas: Use devm_extcon_dev_allocate for extcon_dev
Date: Thu, 24 Apr 2014 09:47:17 -0500 [thread overview]
Message-ID: <20140424144717.GI26661@saruman.home> (raw)
In-Reply-To: <1398342897-23670-10-git-send-email-cw00.choi@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thu, Apr 24, 2014 at 09:34:57PM +0900, Chanwoo Choi wrote:
> This patch use devm_extcon_dev_allocate() to simplify the memory control
> of extcon device.
>
> Cc: Graeme Gregory <gg@slimlogic.co.uk>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Felipe Balbi <balbi@ti.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Tested-by: Felipe Balbi <balbi@ti.com>
*BUT* you need to fix NULL vs ERR_PTR return in your code. The way this
is, we can easily dereference an ERR_PTR because the code doesn't test
for it. I suggest always returning valid pointer or ERR_PTR and avoid
returning NULL at all.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-24 14:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 12:34 [PATCHv3 0/9] extcon: Support devm_extcon_dev_allocate/free() Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 1/9] extcon: Add extcon_dev_allocate/free() to control the memory of extcon device Chanwoo Choi
2014-04-24 14:42 ` Felipe Balbi
2014-04-24 14:58 ` Chanwoo Choi
2014-04-24 15:03 ` Felipe Balbi
2014-04-24 15:06 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 2/9] extcon: Add devm_extcon_dev_allocate/free to manage the resource " Chanwoo Choi
2014-04-24 14:44 ` Felipe Balbi
2014-04-24 15:03 ` Chanwoo Choi
2014-04-24 15:06 ` Felipe Balbi
2014-04-24 15:10 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon_dev Chanwoo Choi
2014-04-24 14:45 ` Felipe Balbi
2014-04-24 15:11 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 4/9] extcon: max77693: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 5/9] extcon: max14577: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 6/9] extcon: arizona: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 7/9] extcon: adc-jack: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 8/9] extcon: gpio: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 9/9] extcon: palmas: " Chanwoo Choi
2014-04-24 14:47 ` Felipe Balbi [this message]
2014-04-24 15:13 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424144717.GI26661@saruman.home \
--to=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=gg@slimlogic.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®