From: Felipe Balbi <balbi@ti.com>
To: Chanwoo Choi <cwchoi00@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>, Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
<gg@slimlogic.co.uk>, Kishon Vijay Abraham I <kishon@ti.com>,
<ckeepax@opensource.wolfsonmicro.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCHv3 1/9] extcon: Add extcon_dev_allocate/free() to control the memory of extcon device
Date: Thu, 24 Apr 2014 10:03:44 -0500 [thread overview]
Message-ID: <20140424150344.GO26661@saruman.home> (raw)
In-Reply-To: <CAGTfZH0+VCvr=JNbq8kbtC2CDN63k28+oSd__6sb+Qy2tQ4_ng@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Hi,
On Thu, Apr 24, 2014 at 11:58:29PM +0900, Chanwoo Choi wrote:
> >> +void extcon_dev_free(struct extcon_dev *edev)
> >> +{
> >> + if (edev)
> >> + kfree(edev);
> >
> > kfree(NULL) is safe
>
> I don't understand about meaning 'kfree(NULL)'.
> Why do I free 'NULL' pointer' instead of 'edev' pointer?
you don't need to check if evdev is valid before calling kfree() on it
because if it happens to be NULL, no cute bunnies will be sacrificed.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-24 15:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 12:34 [PATCHv3 0/9] extcon: Support devm_extcon_dev_allocate/free() Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 1/9] extcon: Add extcon_dev_allocate/free() to control the memory of extcon device Chanwoo Choi
2014-04-24 14:42 ` Felipe Balbi
2014-04-24 14:58 ` Chanwoo Choi
2014-04-24 15:03 ` Felipe Balbi [this message]
2014-04-24 15:06 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 2/9] extcon: Add devm_extcon_dev_allocate/free to manage the resource " Chanwoo Choi
2014-04-24 14:44 ` Felipe Balbi
2014-04-24 15:03 ` Chanwoo Choi
2014-04-24 15:06 ` Felipe Balbi
2014-04-24 15:10 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon_dev Chanwoo Choi
2014-04-24 14:45 ` Felipe Balbi
2014-04-24 15:11 ` Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 4/9] extcon: max77693: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 5/9] extcon: max14577: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 6/9] extcon: arizona: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 7/9] extcon: adc-jack: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 8/9] extcon: gpio: " Chanwoo Choi
2014-04-24 12:34 ` [PATCHv3 9/9] extcon: palmas: " Chanwoo Choi
2014-04-24 14:47 ` Felipe Balbi
2014-04-24 15:13 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424150344.GO26661@saruman.home \
--to=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=gg@slimlogic.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®