mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2 v4] usb: gadget: net2280: Fix NULL pointer dereference
@ 2014-05-15 12:28 Ricardo Ribalda Delgado
  2014-05-15 12:28 ` [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X Ricardo Ribalda Delgado
  0 siblings, 1 reply; 7+ messages in thread
From: Ricardo Ribalda Delgado @ 2014-05-15 12:28 UTC (permalink / raw)
  To: balbi, gregkh, linux-kernel, linux-usb, joe, auttamchandani
  Cc: Ricardo Ribalda Delgado

When DEBUG is enabled driver->driver.name is accessed, but driver
can be NULL

[  174.411689] BUG: unable to handle kernel NULL pointer dereference at 0000000000000040
[  174.429043] RIP: 0010:[<ffffffffa0131ca3>]  [<ffffffffa0131ca3>] net2280_stop+0xa3/0x100 [net2280]
[  174.457910] Call Trace:
[  174.459503]  [<ffffffffa00dd92a>] usb_gadget_remove_driver+0x5a/0xb0 [udc_core]
[  174.462693]  [<ffffffffa00ddd84>] usb_del_gadget_udc+0xb4/0x110 [udc_core]
[  174.464316]  [<ffffffffa012e2bf>] net2280_remove+0x2f/0x1c0 [net2280]

Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
v4: Replace if with terniary operator

 drivers/usb/gadget/net2280.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index 43e5e2f..300b3a7 100644
--- a/drivers/usb/gadget/net2280.c
+++ b/drivers/usb/gadget/net2280.c
@@ -1972,7 +1972,9 @@ static int net2280_stop(struct usb_gadget *_gadget,
 	device_remove_file (&dev->pdev->dev, &dev_attr_function);
 	device_remove_file (&dev->pdev->dev, &dev_attr_queues);
 
-	DEBUG (dev, "unregistered driver '%s'\n", driver->driver.name);
+	DEBUG(dev, "unregistered driver '%s'\n",
+			driver ? driver->driver.name : "");
+
 	return 0;
 }
 
-- 
2.0.0.rc0


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-05-19 10:04 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-15 12:28 [PATCH 1/2 v4] usb: gadget: net2280: Fix NULL pointer dereference Ricardo Ribalda Delgado
2014-05-15 12:28 ` [PATCH 2/2 v4] usb: gadget: net2280: Add support for PLX USB338X Ricardo Ribalda Delgado
2014-05-15 16:07   ` Felipe Balbi
2014-05-15 16:34     ` Ricardo Ribalda Delgado
2014-05-15 19:12     ` Alan Stern
2014-05-15 18:40   ` Joe Perches
2014-05-19 10:04     ` Ricardo Ribalda Delgado

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®