[PATCH] staging: ozwpan: remove redundant NULL check for devs

[PATCH] staging: ozwpan: remove redundant NULL check for devs

[Daeseok Youn]

>From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs

The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So "devs" cannot be NULL, removes NULL check for "devs".

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/staging/ozwpan/ozproto.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index f09acd0..767cac4 100644
--- a/drivers/staging/ozwpan/ozproto.c
+++ b/drivers/staging/ozwpan/ozproto.c
@@ -765,7 +765,7 @@ static char *oz_get_next_device_name(char *s, char *dname, int max_size)
 int oz_protocol_init(char *devs)
 {
 	skb_queue_head_init(&g_rx_queue);
-	if (devs && (devs[0] == '*')) {
+	if (devs[0] == '*') {
 		oz_binding_add(NULL);
 	} else {
 		char d[32];
-- 
1.7.1

Re: [PATCH] staging: ozwpan: remove redundant NULL check for devs

[Dan Carpenter]

On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Fri, 16 May 2014 17:02:04 +0900
> Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
> 

Your patches before were fine.  Why do you have these lines in them now?
Please resend.

Otherwise this looks fine.

regards,
dan carpenter

Re: [PATCH] staging: ozwpan: remove redundant NULL check for devs

[DaeSeok Youn]

Hi, Dan

2014-05-16 18:03 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
>> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@gmail.com>
>> Date: Fri, 16 May 2014 17:02:04 +0900
>> Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
>>
>
> Your patches before were fine.  Why do you have these lines in them now?
> Please resend.
Oh.. I actually made a script for mutt and I didn't notice it.
I will remove these lines and resend it.

Thanks.
Regards,
Daeseok Youn.
>
> Otherwise this looks fine.
>
> regards,
> dan carpenter
>
>