* [PATCH] staging: ozwpan: remove redundant NULL check for devs
@ 2014-05-16 8:08 Daeseok Youn
2014-05-16 9:03 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Daeseok Youn @ 2014-05-16 8:08 UTC (permalink / raw)
To: rupesh.gujare; +Cc: gregkh, devel, linux-kernel
>From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Fri, 16 May 2014 17:02:04 +0900
Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
The "devs" is a pointer to g_net_dev in ozmain.c.
g_net_dev has a default value as empty string.
So "devs" cannot be NULL, removes NULL check for "devs".
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/ozwpan/ozproto.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/ozwpan/ozproto.c b/drivers/staging/ozwpan/ozproto.c
index f09acd0..767cac4 100644
--- a/drivers/staging/ozwpan/ozproto.c
+++ b/drivers/staging/ozwpan/ozproto.c
@@ -765,7 +765,7 @@ static char *oz_get_next_device_name(char *s, char *dname, int max_size)
int oz_protocol_init(char *devs)
{
skb_queue_head_init(&g_rx_queue);
- if (devs && (devs[0] == '*')) {
+ if (devs[0] == '*') {
oz_binding_add(NULL);
} else {
char d[32];
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: ozwpan: remove redundant NULL check for devs
2014-05-16 8:08 [PATCH] staging: ozwpan: remove redundant NULL check for devs Daeseok Youn
@ 2014-05-16 9:03 ` Dan Carpenter
2014-05-16 9:28 ` DaeSeok Youn
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-05-16 9:03 UTC (permalink / raw)
To: Daeseok Youn; +Cc: rupesh.gujare, devel, gregkh, linux-kernel
On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Fri, 16 May 2014 17:02:04 +0900
> Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
>
Your patches before were fine. Why do you have these lines in them now?
Please resend.
Otherwise this looks fine.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: ozwpan: remove redundant NULL check for devs
2014-05-16 9:03 ` Dan Carpenter
@ 2014-05-16 9:28 ` DaeSeok Youn
0 siblings, 0 replies; 3+ messages in thread
From: DaeSeok Youn @ 2014-05-16 9:28 UTC (permalink / raw)
To: Dan Carpenter; +Cc: rupesh.gujare, devel, Greg KH, linux-kernel
Hi, Dan
2014-05-16 18:03 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, May 16, 2014 at 05:08:10PM +0900, Daeseok Youn wrote:
>> >From 1cebea7a40490d0d0b122eb444a105d424af42e6 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@gmail.com>
>> Date: Fri, 16 May 2014 17:02:04 +0900
>> Subject: [PATCH] staging: ozwpan: remove redundant NULL check for devs
>>
>
> Your patches before were fine. Why do you have these lines in them now?
> Please resend.
Oh.. I actually made a script for mutt and I didn't notice it.
I will remove these lines and resend it.
Thanks.
Regards,
Daeseok Youn.
>
> Otherwise this looks fine.
>
> regards,
> dan carpenter
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-16 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-16 8:08 [PATCH] staging: ozwpan: remove redundant NULL check for devs Daeseok Youn
2014-05-16 9:03 ` Dan Carpenter
2014-05-16 9:28 ` DaeSeok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®