* Re: [PATCH 12/14] block: Add specific data integrity errors
[not found] ` <1401334128-15499-13-git-send-email-martin.petersen@oracle.com>
@ 2014-06-11 16:54 ` Christoph Hellwig
2014-06-12 2:16 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2014-06-11 16:54 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: axboe, nab, sagig, linux-scsi, linux-kernel, linux-api
On Wed, May 28, 2014 at 11:28:46PM -0400, Martin K. Petersen wrote:
> Introduce a set of error codes that can be used by the block integrity
> subsystem to signal which class of error was encountered by either the
> I/O controller or the storage device.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
New error code should be run past linux-kernel and linux-api.
I'd also love to see something catching these so that they don't
leak to userspace.
In fact I'd really prefer to not overload the errno space with something
so block specific if possible - we use very few errnos in the
bio/request errors, and cleaning them up to use a block-specific error
type would be the best solution.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 12/14] block: Add specific data integrity errors
2014-06-11 16:54 ` [PATCH 12/14] block: Add specific data integrity errors Christoph Hellwig
@ 2014-06-12 2:16 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2014-06-12 2:16 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Martin K. Petersen, axboe, nab, sagig, linux-scsi, linux-kernel,
linux-api
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>> Introduce a set of error codes that can be used by the block
>> integrity subsystem to signal which class of error was encountered by
>> either the I/O controller or the storage device.
Christoph> I'd also love to see something catching these so that they
Christoph> don't leak to userspace.
This patch was really meant as an RFC. But it is absolutely my intent to
expose these to userspace. Albeit only to applications that supply or
request protection information via Darrick's aio extensions.
I also use these errors extensively in my test utilities to verify that
the correct problem gets detected by the correct entity when I inject an
error.
I should add that in the past I had a separate error status inside the
bip that contained the data integrity specific errors. But that involved
all sorts of evil hacks when bios were cloned, split and stacked. After
talking to nab about his needs for target I figured it was better to
just define new error codes and handle them like Hannes did for the
extended SCSI errors.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-12 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1401334128-15499-1-git-send-email-martin.petersen@oracle.com>
[not found] ` <1401334128-15499-13-git-send-email-martin.petersen@oracle.com>
2014-06-11 16:54 ` [PATCH 12/14] block: Add specific data integrity errors Christoph Hellwig
2014-06-12 2:16 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®