Re: [PATCH] hwmon: (gpio-fan) Change name used in hwmon_device_register_with_groups

Re: [PATCH] hwmon: (gpio-fan) Change name used in hwmon_device_register_with_groups

[Guenter Roeck]

On Wed, Jun 25, 2014 at 10:00:31PM +0200, Julien D'Ascenzio wrote:
> Since commit 648cd48c9e566f53c5df30d79857e0937ae13b09
> The hwmon name attributes must not include '-' so the name must be
> rename from gpio-fan to gpio_fan
> 
> Signed-off-by: Julien D'Ascenzio <jdascenzio@yahoo.fr>

Good catch. Applied.

Thanks,
Guenter

Re: [PATCH] hwmon: (gpio-fan) Change name used in hwmon_device_register_with_groups

[Jean Delvare]

On Wed, 25 Jun 2014 22:00:31 +0200, Julien D'Ascenzio wrote:
> Since commit 648cd48c9e566f53c5df30d79857e0937ae13b09
> The hwmon name attributes must not include '-' so the name must be
> rename from gpio-fan to gpio_fan
> 
> Signed-off-by: Julien D'Ascenzio <jdascenzio@yahoo.fr>
> ---
>  drivers/hwmon/gpio-fan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
> index 73181be..160ca00 100644
> --- a/drivers/hwmon/gpio-fan.c
> +++ b/drivers/hwmon/gpio-fan.c
> @@ -538,7 +538,7 @@ static int gpio_fan_probe(struct platform_device *pdev)
>  
>  	/* Make this driver part of hwmon class. */
>  	fan_data->hwmon_dev = hwmon_device_register_with_groups(&pdev->dev,
> -						"gpio-fan", fan_data,
> +						"gpio_fan", fan_data,
>  						gpio_fan_groups);
>  	if (IS_ERR(fan_data->hwmon_dev))
>  		return PTR_ERR(fan_data->hwmon_dev);

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support