* [PATCH] Doc: mfd: as3722: Add details of optional missing property
@ 2014-06-09 7:03 Laxman Dewangan
2014-06-16 9:52 ` Lee Jones
2014-07-09 15:34 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Laxman Dewangan @ 2014-06-09 7:03 UTC (permalink / raw)
To: lee.jones
Cc: robh+dt, swarren, devicetree, linux-kernel, mark.rutland,
Laxman Dewangan
Add details of following properties which are used on driver but
not documented on DT binding document.
- ams,enable-internal-int-pullup
- ams,enable-internal-i2c-pullup
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reported-by: Lee Jones <lee.jones@linaro.org>
---
Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
index 8edcb9b..4f64b2a 100644
--- a/Documentation/devicetree/bindings/mfd/as3722.txt
+++ b/Documentation/devicetree/bindings/mfd/as3722.txt
@@ -13,6 +13,14 @@ Required properties:
The second cell is the flags, encoded as the trigger masks from binding document
interrupts.txt, using dt-bindings/irq.
+Optional properties:
+--------------------
+- ams,enable-internal-int-pullup: Boolean property, to enable internal pullup on
+ interrupt pin. Missing this will disable internal pullup on INT pin.
+- ams,enable-internal-i2c-pullup: Boolean property, to enable internal pullup on
+ i2c scl/sda pins. Missing this will disable internal pullup on i2c
+ scl/sda lines.
+
Optional submodule and their properties:
=======================================
--
1.8.1.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property
2014-06-09 7:03 [PATCH] Doc: mfd: as3722: Add details of optional missing property Laxman Dewangan
@ 2014-06-16 9:52 ` Lee Jones
2014-07-07 10:49 ` Linus Walleij
2014-07-09 15:34 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2014-06-16 9:52 UTC (permalink / raw)
To: Laxman Dewangan
Cc: robh+dt, swarren, devicetree, linux-kernel, mark.rutland, linus.walleij
CC'ing Linus as he had an opinion.
On Mon, 09 Jun 2014, Laxman Dewangan wrote:
> Add details of following properties which are used on driver but
> not documented on DT binding document.
> - ams,enable-internal-int-pullup
> - ams,enable-internal-i2c-pullup
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index 8edcb9b..4f64b2a 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -13,6 +13,14 @@ Required properties:
> The second cell is the flags, encoded as the trigger masks from binding document
> interrupts.txt, using dt-bindings/irq.
>
> +Optional properties:
> +--------------------
> +- ams,enable-internal-int-pullup: Boolean property, to enable internal pullup on
> + interrupt pin. Missing this will disable internal pullup on INT pin.
> +- ams,enable-internal-i2c-pullup: Boolean property, to enable internal pullup on
> + i2c scl/sda pins. Missing this will disable internal pullup on i2c
> + scl/sda lines.
> +
> Optional submodule and their properties:
> =======================================
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property
2014-06-16 9:52 ` Lee Jones
@ 2014-07-07 10:49 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-07-07 10:49 UTC (permalink / raw)
To: Lee Jones
Cc: Laxman Dewangan, Rob Herring, Stephen Warren, devicetree,
linux-kernel, Mark Rutland
On Mon, Jun 16, 2014 at 11:52 AM, Lee Jones <lee.jones@linaro.org> wrote:
> CC'ing Linus as he had an opinion.
>
> On Mon, 09 Jun 2014, Laxman Dewangan wrote:
>> Add details of following properties which are used on driver but
>> not documented on DT binding document.
>> - ams,enable-internal-int-pullup
>> - ams,enable-internal-i2c-pullup
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Reported-by: Lee Jones <lee.jones@linaro.org>
I can live with this.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Doc: mfd: as3722: Add details of optional missing property
2014-06-09 7:03 [PATCH] Doc: mfd: as3722: Add details of optional missing property Laxman Dewangan
2014-06-16 9:52 ` Lee Jones
@ 2014-07-09 15:34 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-07-09 15:34 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: robh+dt, swarren, devicetree, linux-kernel, mark.rutland
On Mon, 09 Jun 2014, Laxman Dewangan wrote:
> Add details of following properties which are used on driver but
> not documented on DT binding document.
> - ams,enable-internal-int-pullup
> - ams,enable-internal-i2c-pullup
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Reported-by: Lee Jones <lee.jones@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/as3722.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied with Linus' Ack, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-09 15:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09 7:03 [PATCH] Doc: mfd: as3722: Add details of optional missing property Laxman Dewangan
2014-06-16 9:52 ` Lee Jones
2014-07-07 10:49 ` Linus Walleij
2014-07-09 15:34 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®