* [PATCH] Staging: panel: fixed frivilous else statement warning
@ 2014-07-10 10:34 Vincent Heuken
2014-07-18 9:35 ` Willy Tarreau
0 siblings, 1 reply; 2+ messages in thread
From: Vincent Heuken @ 2014-07-10 10:34 UTC (permalink / raw)
To: willy, gregkh, armand.bastien, domdevlin, monamagarwal123,
julia.lawall, arnd
Cc: devel, linux-kernel, Vincent Heuken
Fixed one instance of the following checkpatch.pl warning in
panel.c:
WARNING: else is not generally useful after a break or return
Signed-off-by: Vincent Heuken <me@vincentheuken.com>
---
drivers/staging/panel/panel.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index 4e92293..6d1a320 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1800,11 +1800,12 @@ static inline int input_state_high(struct logical_input *input)
input->high_timer++;
}
return 1;
- } else {
- /* else signal falling down. Let's fall through. */
- input->state = INPUT_ST_FALLING;
- input->fall_timer = 0;
}
+
+ /* else signal falling down. Let's fall through. */
+ input->state = INPUT_ST_FALLING;
+ input->fall_timer = 0;
+
return 0;
}
--
2.0.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: panel: fixed frivilous else statement warning
2014-07-10 10:34 [PATCH] Staging: panel: fixed frivilous else statement warning Vincent Heuken
@ 2014-07-18 9:35 ` Willy Tarreau
0 siblings, 0 replies; 2+ messages in thread
From: Willy Tarreau @ 2014-07-18 9:35 UTC (permalink / raw)
To: Vincent Heuken
Cc: gregkh, armand.bastien, domdevlin, monamagarwal123, julia.lawall,
arnd, devel, linux-kernel
On Thu, Jul 10, 2014 at 03:34:28AM -0700, Vincent Heuken wrote:
> Fixed one instance of the following checkpatch.pl warning in
> panel.c:
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Vincent Heuken <me@vincentheuken.com>
Acked-By: Willy Tarreau <w@1wt.eu>
Vincent, are you currently reviewing the driver ? We'd like someone
to completely review it to decide if it can be moved out of staging
or needs to be dropped (or fixed).
Thanks,
Willy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-18 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-10 10:34 [PATCH] Staging: panel: fixed frivilous else statement warning Vincent Heuken
2014-07-18 9:35 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®