From: Pavel Machek <pavel@denx.de>
To: Kalle Valo <kvalo@adurom.com>
Cc: Borislav Petkov <bp@alien8.de>, Joe Perches <joe@perches.com>,
Richard Weinberger <richard@nod.at>,
akpm@linux-foundation.org, apw@canonical.com, tytso@mit.edu,
dwalter@google.com, bp@suse.de, neilb@suse.de, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option
Date: Mon, 4 Aug 2014 16:30:29 +0200 [thread overview]
Message-ID: <20140804143029.GC24261@amd.pavel.ucw.cz> (raw)
In-Reply-To: <87vbqq9d51.fsf@purkki.adurom.net>
On Tue 2014-07-22 08:27:22, Kalle Valo wrote:
> Borislav Petkov <bp@alien8.de> writes:
>
> > No, checkpatch should only check patches and not whole file. It is
> > wrong. Fullstop.
>
> Please don't remove --file, I use it all the time when maintaining
> ath6kl and ath10k. It's a lot easier in my workflow to test the whole
> driver in one go than start testing individual patches.
Exactly. Also, with --file, you have nice place to write warning
"please don't do cleanups just because of this"...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-08-04 14:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:34 Richard Weinberger
2014-07-17 15:38 ` Borislav Petkov
2014-07-17 15:51 ` Joe Perches
2014-07-17 16:02 ` Borislav Petkov
2014-07-17 16:24 ` Joe Perches
2014-07-22 5:27 ` Kalle Valo
2014-08-04 14:30 ` Pavel Machek [this message]
2014-07-17 22:43 ` Thomas Gleixner
2014-07-18 7:29 ` Guenter Roeck
2014-07-18 8:23 ` Borislav Petkov
2014-07-18 13:37 ` Guenter Roeck
2014-07-18 13:46 ` Richard Weinberger
2014-07-18 13:56 ` Guenter Roeck
2014-07-18 14:22 ` Borislav Petkov
2014-07-18 14:21 ` Christoph Hellwig
2014-07-18 14:27 ` Borislav Petkov
2014-07-18 14:43 ` Guenter Roeck
2014-07-18 14:56 ` Borislav Petkov
2014-07-18 14:17 ` Lars-Peter Clausen
2014-07-18 14:24 ` Borislav Petkov
2014-07-18 14:35 ` Joe Perches
2014-07-18 14:49 ` Borislav Petkov
2014-07-18 14:57 ` Joe Perches
2014-07-18 15:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804143029.GC24261@amd.pavel.ucw.cz \
--to=pavel@denx.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=dwalter@google.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=kvalo@adurom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®