From: Thomas Gleixner <tglx@linutronix.de>
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard@nod.at>,
akpm@linux-foundation.org, apw@canonical.com, tytso@mit.edu,
dwalter@google.com, bp@suse.de, neilb@suse.de, hch@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Remove --file option
Date: Fri, 18 Jul 2014 00:43:06 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1407180039510.24854@nanos> (raw)
In-Reply-To: <1405612283.12363.10.camel@joe-AO725>
On Thu, 17 Jul 2014, Joe Perches wrote:
> On Thu, 2014-07-17 at 17:34 +0200, Richard Weinberger wrote:
> > checkpatch.pl is a nice tool to find issues in patches.
>
> grep is a similar tool, just less automated.
>
> > Sadly this tool gets more and more abused by various people to create
> > style cleanups for source files within the kernel.
> > In order to deal with that bad habit let's remove the --file option
> > and bring checkpatch.pl back to its original purpose.
>
> Any tool can be misused.
>
> diff -urN /dev/null $file | ./scripts/checkpatch.pl -
>
> does the same thing as --file so I don't see any real
> fundamental difference.
There is a fundamental difference:
Coming up with the above requires actual brain involvement.
./scripts/checkpatch.pl -f
not so much.
So, for Richards patch:
Acked-and-heartely-welcomed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2014-07-17 22:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:34 Richard Weinberger
2014-07-17 15:38 ` Borislav Petkov
2014-07-17 15:51 ` Joe Perches
2014-07-17 16:02 ` Borislav Petkov
2014-07-17 16:24 ` Joe Perches
2014-07-22 5:27 ` Kalle Valo
2014-08-04 14:30 ` Pavel Machek
2014-07-17 22:43 ` Thomas Gleixner [this message]
2014-07-18 7:29 ` Guenter Roeck
2014-07-18 8:23 ` Borislav Petkov
2014-07-18 13:37 ` Guenter Roeck
2014-07-18 13:46 ` Richard Weinberger
2014-07-18 13:56 ` Guenter Roeck
2014-07-18 14:22 ` Borislav Petkov
2014-07-18 14:21 ` Christoph Hellwig
2014-07-18 14:27 ` Borislav Petkov
2014-07-18 14:43 ` Guenter Roeck
2014-07-18 14:56 ` Borislav Petkov
2014-07-18 14:17 ` Lars-Peter Clausen
2014-07-18 14:24 ` Borislav Petkov
2014-07-18 14:35 ` Joe Perches
2014-07-18 14:49 ` Borislav Petkov
2014-07-18 14:57 ` Joe Perches
2014-07-18 15:06 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1407180039510.24854@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@suse.de \
--cc=dwalter@google.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®