* [PATCH 1/1] Fix some code style issues
@ 2014-08-19 11:57 Yannis Damigos
2014-08-19 12:41 ` Greg Kroah-Hartman
0 siblings, 1 reply; 9+ messages in thread
From: Yannis Damigos @ 2014-08-19 11:57 UTC (permalink / raw)
To: Philipp Zabel, Russell King, Fabio Estevam, devel
Cc: Greg Kroah-Hartman, linux-kernel, Yannis Damigos
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
---
drivers/staging/imx-drm/ipuv3-crtc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..c4c6455 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
- return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
- 0, 0, mode->hdisplay, mode->vdisplay,
- x, y, mode->hdisplay, mode->vdisplay);
+ return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
+ crtc->primary->fb, 0, 0, mode->hdisplay, mode->vdisplay,
+ x, y, mode->hdisplay, mode->vdisplay);
}
static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
@@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
if (ipu_crtc->newfb) {
ipu_crtc->newfb = NULL;
- ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
+ ipu_plane_set_base(ipu_crtc->plane[0],
+ ipu_crtc->base.primary->fb,
ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
--
2.0.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] Fix some code style issues
2014-08-19 11:57 [PATCH 1/1] Fix some code style issues Yannis Damigos
@ 2014-08-19 12:41 ` Greg Kroah-Hartman
2014-08-19 13:59 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
0 siblings, 1 reply; 9+ messages in thread
From: Greg Kroah-Hartman @ 2014-08-19 12:41 UTC (permalink / raw)
To: Yannis Damigos
Cc: Philipp Zabel, Russell King, Fabio Estevam, devel, linux-kernel
On Tue, Aug 19, 2014 at 02:57:11PM +0300, Yannis Damigos wrote:
> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
Your subject: line needs a lot of work. What part of the kernel are you
changing?
Then you need some description in the body of the changelog saying _why_
you made this change, and what you changed.
Please be more descriptive.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 12:41 ` Greg Kroah-Hartman
@ 2014-08-19 13:59 ` Yannis Damigos
2014-08-19 14:05 ` Philipp Zabel
0 siblings, 1 reply; 9+ messages in thread
From: Yannis Damigos @ 2014-08-19 13:59 UTC (permalink / raw)
To: Philipp Zabel, Russell King, Fabio Estevam, devel, Greg Kroah-Hartman
Cc: linux-kernel, Yannis Damigos
This is a patch to the ipuv3-crtc.c file that fixes up two "lines
over 80 characters" warnings found by the checkpatch.pl tool.
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
---
drivers/staging/imx-drm/ipuv3-crtc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..c4c6455 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
- return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
- 0, 0, mode->hdisplay, mode->vdisplay,
- x, y, mode->hdisplay, mode->vdisplay);
+ return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
+ crtc->primary->fb, 0, 0, mode->hdisplay, mode->vdisplay,
+ x, y, mode->hdisplay, mode->vdisplay);
}
static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
@@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
if (ipu_crtc->newfb) {
ipu_crtc->newfb = NULL;
- ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
+ ipu_plane_set_base(ipu_crtc->plane[0],
+ ipu_crtc->base.primary->fb,
ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
--
2.0.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 13:59 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
@ 2014-08-19 14:05 ` Philipp Zabel
2014-08-19 14:36 ` Yannis Damigos
0 siblings, 1 reply; 9+ messages in thread
From: Philipp Zabel @ 2014-08-19 14:05 UTC (permalink / raw)
To: Yannis Damigos
Cc: Russell King, Fabio Estevam, devel, Greg Kroah-Hartman, linux-kernel
Am Dienstag, den 19.08.2014, 16:59 +0300 schrieb Yannis Damigos:
> This is a patch to the ipuv3-crtc.c file that fixes up two "lines
> over 80 characters" warnings found by the checkpatch.pl tool.
>
> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
> ---
> drivers/staging/imx-drm/ipuv3-crtc.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
> index 720868b..c4c6455 100644
> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
> @@ -201,9 +201,9 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> return ret;
> }
>
> - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
> - 0, 0, mode->hdisplay, mode->vdisplay,
> - x, y, mode->hdisplay, mode->vdisplay);
> + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
> + crtc->primary->fb, 0, 0, mode->hdisplay, mode->vdisplay,
> + x, y, mode->hdisplay, mode->vdisplay);
> }
>
> static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
This doesn't improve readability, though. Can we keep the alignment of
the x/y/width/height parameters?
> @@ -227,7 +227,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
>
> if (ipu_crtc->newfb) {
> ipu_crtc->newfb = NULL;
> - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
> + ipu_plane_set_base(ipu_crtc->plane[0],
> + ipu_crtc->base.primary->fb,
> ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
> ipu_crtc_handle_pageflip(ipu_crtc);
> }
regards
Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread* (no subject)
2014-08-19 14:05 ` Philipp Zabel
@ 2014-08-19 14:36 ` Yannis Damigos
2014-08-19 14:36 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
0 siblings, 1 reply; 9+ messages in thread
From: Yannis Damigos @ 2014-08-19 14:36 UTC (permalink / raw)
To: Philipp Zabel, Russell King, Fabio Estevam, devel, Greg Kroah-Hartman
Cc: linux-kernel
I updated the patch to keep the alignment of the
x/y/width/height parameters for readability.
regards,
Yannis
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 14:36 ` Yannis Damigos
@ 2014-08-19 14:36 ` Yannis Damigos
2014-08-19 15:03 ` Russell King - ARM Linux
0 siblings, 1 reply; 9+ messages in thread
From: Yannis Damigos @ 2014-08-19 14:36 UTC (permalink / raw)
To: Philipp Zabel, Russell King, Fabio Estevam, devel, Greg Kroah-Hartman
Cc: linux-kernel, Yannis Damigos
This is a patch to the ipuv3-crtc.c file that fixes up two "lines
over 80 characters" warnings found by the checkpatch.pl tool,
keeping the alignment of the x/y/width/height parameters for
readability.
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
---
drivers/staging/imx-drm/ipuv3-crtc.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..d6657a0 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,9 +201,10 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
- return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
- 0, 0, mode->hdisplay, mode->vdisplay,
- x, y, mode->hdisplay, mode->vdisplay);
+ return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
+ crtc->primary->fb,
+ 0, 0, mode->hdisplay, mode->vdisplay,
+ x, y, mode->hdisplay, mode->vdisplay);
}
static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
@@ -227,7 +228,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
if (ipu_crtc->newfb) {
ipu_crtc->newfb = NULL;
- ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
+ ipu_plane_set_base(ipu_crtc->plane[0],
+ ipu_crtc->base.primary->fb,
ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
--
2.0.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 14:36 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
@ 2014-08-19 15:03 ` Russell King - ARM Linux
2014-08-19 15:26 ` Yannis Damigos
0 siblings, 1 reply; 9+ messages in thread
From: Russell King - ARM Linux @ 2014-08-19 15:03 UTC (permalink / raw)
To: Yannis Damigos
Cc: Philipp Zabel, Fabio Estevam, devel, Greg Kroah-Hartman, linux-kernel
On Tue, Aug 19, 2014 at 05:36:10PM +0300, Yannis Damigos wrote:
> diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
> index 720868b..d6657a0 100644
> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
> @@ -201,9 +201,10 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> return ret;
> }
>
> - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
> - 0, 0, mode->hdisplay, mode->vdisplay,
> - x, y, mode->hdisplay, mode->vdisplay);
> + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
> + crtc->primary->fb,
> + 0, 0, mode->hdisplay, mode->vdisplay,
> + x, y, mode->hdisplay, mode->vdisplay);
Why change the indentation like this? There is a wisdom which suggests
that it's better to align the arguments with the function call's first
argument, unless there is a strong reason not to. In this case, I can't
see a strong reason to change the indentation to some different style
here.
> }
>
> static void ipu_crtc_handle_pageflip(struct ipu_crtc *ipu_crtc)
> @@ -227,7 +228,8 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
>
> if (ipu_crtc->newfb) {
> ipu_crtc->newfb = NULL;
> - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
> + ipu_plane_set_base(ipu_crtc->plane[0],
> + ipu_crtc->base.primary->fb,
> ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
What may make better sense here is:
struct ipu_plane *plane = ipu_crtc->plane[0];
ipu_crtc->newfb = NULL;
ipu_plane_set_base(plane, ipu_crtc->base.primary->fb,
plane->x, plane->y);
which to me looks loads nicer.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 15:03 ` Russell King - ARM Linux
@ 2014-08-19 15:26 ` Yannis Damigos
2014-08-19 15:42 ` Philipp Zabel
0 siblings, 1 reply; 9+ messages in thread
From: Yannis Damigos @ 2014-08-19 15:26 UTC (permalink / raw)
To: Philipp Zabel, Russell King, Fabio Estevam, devel, Greg Kroah-Hartman
Cc: linux-kernel, Yannis Damigos
This is a patch to the ipuv3-crtc.c file that fixes up two "lines
over 80 characters" warnings found by the checkpatch.pl tool,
keeping the alignment of the x/y/width/height parameters for
readability.
Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
---
drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
index 720868b..11e84a2 100644
--- a/drivers/staging/imx-drm/ipuv3-crtc.c
+++ b/drivers/staging/imx-drm/ipuv3-crtc.c
@@ -201,7 +201,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
return ret;
}
- return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
+ return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
+ crtc->primary->fb,
0, 0, mode->hdisplay, mode->vdisplay,
x, y, mode->hdisplay, mode->vdisplay);
}
@@ -226,9 +227,11 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
imx_drm_handle_vblank(ipu_crtc->imx_crtc);
if (ipu_crtc->newfb) {
+ struct ipu_plane *plane = ipu_crtc->plane[0];
+
ipu_crtc->newfb = NULL;
- ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
- ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
+ ipu_plane_set_base(plane, ipu_crtc->base.primary->fb,
+ plane->x, plane->y);
ipu_crtc_handle_pageflip(ipu_crtc);
}
--
2.0.4
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed.
2014-08-19 15:26 ` Yannis Damigos
@ 2014-08-19 15:42 ` Philipp Zabel
0 siblings, 0 replies; 9+ messages in thread
From: Philipp Zabel @ 2014-08-19 15:42 UTC (permalink / raw)
To: Yannis Damigos
Cc: Russell King, Fabio Estevam, devel, Greg Kroah-Hartman, linux-kernel
Am Dienstag, den 19.08.2014, 18:26 +0300 schrieb Yannis Damigos:
> This is a patch to the ipuv3-crtc.c file that fixes up two "lines
> over 80 characters" warnings found by the checkpatch.pl tool,
> keeping the alignment of the x/y/width/height parameters for
> readability.
>
> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com>
> ---
> drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c
> index 720868b..11e84a2 100644
> --- a/drivers/staging/imx-drm/ipuv3-crtc.c
> +++ b/drivers/staging/imx-drm/ipuv3-crtc.c
> @@ -201,7 +201,8 @@ static int ipu_crtc_mode_set(struct drm_crtc *crtc,
> return ret;
> }
>
> - return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode, crtc->primary->fb,
> + return ipu_plane_mode_set(ipu_crtc->plane[0], crtc, mode,
> + crtc->primary->fb,
> 0, 0, mode->hdisplay, mode->vdisplay,
> x, y, mode->hdisplay, mode->vdisplay);
> }
> @@ -226,9 +227,11 @@ static irqreturn_t ipu_irq_handler(int irq, void *dev_id)
> imx_drm_handle_vblank(ipu_crtc->imx_crtc);
>
> if (ipu_crtc->newfb) {
> + struct ipu_plane *plane = ipu_crtc->plane[0];
> +
> ipu_crtc->newfb = NULL;
> - ipu_plane_set_base(ipu_crtc->plane[0], ipu_crtc->base.primary->fb,
> - ipu_crtc->plane[0]->x, ipu_crtc->plane[0]->y);
> + ipu_plane_set_base(plane, ipu_crtc->base.primary->fb,
> + plane->x, plane->y);
> ipu_crtc_handle_pageflip(ipu_crtc);
> }
Yes, that does look better.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-08-19 15:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-19 11:57 [PATCH 1/1] Fix some code style issues Yannis Damigos
2014-08-19 12:41 ` Greg Kroah-Hartman
2014-08-19 13:59 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
2014-08-19 14:05 ` Philipp Zabel
2014-08-19 14:36 ` Yannis Damigos
2014-08-19 14:36 ` [PATCH 1/1] staging: imx-drm: Lines over 80 characters fixed Yannis Damigos
2014-08-19 15:03 ` Russell King - ARM Linux
2014-08-19 15:26 ` Yannis Damigos
2014-08-19 15:42 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®