* [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
@ 2014-09-29 7:59 James Ban
2014-09-30 12:45 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: James Ban @ 2014-09-29 7:59 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Support Opensource, LKML; +Cc: David Dajun Chen
This is a patch for fixing a bug about mask bit operation.
Signed-off-by: James Ban <james.ban.opensource@diasemi.com>
---
This patch is relative to linux-next repository tag next-20140926.
drivers/regulator/da9211-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/da9211-regulator.c b/drivers/regulator/da9211-regulator.c
index f47adf3..c78d210 100644
--- a/drivers/regulator/da9211-regulator.c
+++ b/drivers/regulator/da9211-regulator.c
@@ -376,7 +376,7 @@ static int da9211_regulator_init(struct da9211 *chip)
if (chip->chip_irq != 0) {
ret = regmap_update_bits(chip->regmap,
- DA9211_REG_MASK_B, DA9211_M_OV_CURR_A << i, 1);
+ DA9211_REG_MASK_B, DA9211_M_OV_CURR_A << i, 0);
if (ret < 0) {
dev_err(chip->dev,
"Failed to update mask reg: %d\n", ret);
--
end-of-patch for regulator: DA9211 : Fix a bug in update of mask bit V1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
2014-09-29 7:59 [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit James Ban
@ 2014-09-30 12:45 ` Mark Brown
2014-10-01 1:02 ` Opensource [James Seong-Won Ban]
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2014-09-30 12:45 UTC (permalink / raw)
To: James Ban; +Cc: Liam Girdwood, Support Opensource, LKML, David Dajun Chen
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
On Mon, Sep 29, 2014 at 04:59:20PM +0900, James Ban wrote:
> This is a patch for fixing a bug about mask bit operation.
Applied, but please try to make sure that your changelogs are more
descriptive - what is the bug? Please also use subject lines matching
the style for the subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
2014-09-30 12:45 ` Mark Brown
@ 2014-10-01 1:02 ` Opensource [James Seong-Won Ban]
2014-10-01 11:45 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Opensource [James Seong-Won Ban] @ 2014-10-01 1:02 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, Support Opensource, LKML, David Dajun Chen
On Tuesday, September 30, 2014 9:45 PM Mark Brown wrote:
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Tuesday, September 30, 2014 9:45 PM
> To: Opensource [James Seong-Won Ban]
> Cc: Liam Girdwood; Support Opensource; LKML; David Dajun Chen
> Subject: Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
>
> On Mon, Sep 29, 2014 at 04:59:20PM +0900, James Ban wrote:
> > This is a patch for fixing a bug about mask bit operation.
>
> Applied, but please try to make sure that your changelogs are more
> descriptive - what is the bug? Please also use subject lines matching
> the style for the subsystem.
The proper operation of mask bit should be set as '0' for enabling the interrupt.
The result of mask operation at previous code was the same to new one.
But the meaning in the previous code was to set mask bit as '1'.
What is subject line you said?
If you give me an example, it would be very helpful to me.
Regards,
James
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
2014-10-01 1:02 ` Opensource [James Seong-Won Ban]
@ 2014-10-01 11:45 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2014-10-01 11:45 UTC (permalink / raw)
To: Opensource [James Seong-Won Ban]
Cc: Liam Girdwood, Support Opensource, LKML, David Dajun Chen
[-- Attachment #1: Type: text/plain, Size: 788 bytes --]
On Wed, Oct 01, 2014 at 01:02:27AM +0000, Opensource [James Seong-Won Ban] wrote:
> > Applied, but please try to make sure that your changelogs are more
> > descriptive - what is the bug? Please also use subject lines matching
> > the style for the subsystem.
> The proper operation of mask bit should be set as '0' for enabling the interrupt.
> The result of mask operation at previous code was the same to new one.
> But the meaning in the previous code was to set mask bit as '1'.
Right, the point is that this information should've gone in the
changelog - please bear this in mind for future patches.
> What is subject line you said?
> If you give me an example, it would be very helpful to me.
git shortlog drivers/regulator. The capitalisation and extra spaces are
both off.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-01 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-29 7:59 [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit James Ban
2014-09-30 12:45 ` Mark Brown
2014-10-01 1:02 ` Opensource [James Seong-Won Ban]
2014-10-01 11:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®