From: Tejun Heo <tj@kernel.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
lizefan@huawei.com, anton@samba.org, svaidy@linux.vnet.ibm.com,
rjw@rjwysocki.net, paulmck@linux.vnet.ibm.com, mingo@kernel.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant
Date: Thu, 9 Oct 2014 09:06:11 -0400 [thread overview]
Message-ID: <20141009130611.GA14387@htj.dyndns.org> (raw)
In-Reply-To: <54364564.3090305@linux.vnet.ibm.com>
On Thu, Oct 09, 2014 at 01:50:52PM +0530, Preeti U Murthy wrote:
> However what remains to be answered is that the V2 of cgroup design -
> the default hierarchy, tracks hotplug operations for children cgroups as
> well. Tejun, Li, will not the concerns that Peter raised above hold for
> the default hierarchy as well?
I don't think the legacy one is a good design. Kernel shouldn't lose
configurations in an irreversible way and the legacy one is also
making random cpuset flips by migrating tasks upwards anyway. In
terms of hotunplug behavior, the legacy and unified ones behave the
same. The only difference is that the configuration is independent of
the current state and the configured behavior is restored when the
cpus come back. The other side is that the legacy hierarchy behavior
simply can't be allowed when the hierarchy is shared among multiple
controllers as in the unified hierarchy. It affects all other
controllers attached to the hierarchy.
That said, we can't change the behavior on the legacy one. It's a
very userland visible behavior. We simply can't change it, so
unfortunately you're stuck with it at least on the legacy hierarchy.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-10-09 13:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 7:07 Preeti U Murthy
2014-10-08 8:07 ` Peter Zijlstra
2014-10-08 9:37 ` Preeti U Murthy
2014-10-08 10:18 ` Peter Zijlstra
2014-10-09 8:20 ` Preeti U Murthy
2014-10-09 8:30 ` Peter Zijlstra
2014-10-09 8:32 ` Peter Zijlstra
2014-10-09 13:06 ` Tejun Heo [this message]
2014-10-09 13:47 ` Peter Zijlstra
2014-10-09 13:59 ` Tejun Heo
2015-04-02 6:56 ` Preeti U Murthy
2015-04-06 17:47 ` Tejun Heo
2015-04-09 21:13 ` Serge E. Hallyn
2015-04-10 14:14 ` Preeti U Murthy
2014-10-08 14:54 Raghavendra KT
2014-10-09 5:12 ` Preeti U Murthy
2014-10-09 9:42 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009130611.GA14387@htj.dyndns.org \
--to=tj@kernel.org \
--cc=anton@samba.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome