mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
	lizefan@huawei.com, anton@samba.org, svaidy@linux.vnet.ibm.com,
	rjw@rjwysocki.net, paulmck@linux.vnet.ibm.com, mingo@kernel.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant
Date: Thu, 9 Oct 2014 09:59:24 -0400	[thread overview]
Message-ID: <20141009135924.GE14387@htj.dyndns.org> (raw)
In-Reply-To: <20141009134758.GU10832@worktop.programming.kicks-ass.net>

Hello, Peter.

On Thu, Oct 09, 2014 at 03:47:58PM +0200, Peter Zijlstra wrote:
> You do know we disagree on this :-)

Yeap. :)

...
> And while you all can try and pretend hotplug is a 'normal' and 'sane'
> operation with cpusets, the same failure more very much still exists
> with the regular affinity controls. So you can pretend all you want, but
> its a clear and utter fail.
> 
> You cannot give the kernel contradictory instructions and then pretend
> all is well and dandy.

But even if you view it that way, the current legacy implementation is
deficient to say the least.  It puts way too much trust in the
userland while not giving it mechanisms to deal with the situation.
It's not like the userland is an all-knowing entity and short of the
printk there's no way to detect such automatic migrations or to know
the previous state.  If this actually was seen as a configuration
failure, it would have made a lot more sense to just not run those
tasks unless they're SIGKILL'd.

This is all moot tho.  We can't change the behavior for the legacy
hierarchies and we can't auto-migrate for the unified hierarchy, so
there isn't much left to decide.

Thanks.

-- 
tejun

  reply	other threads:[~2014-10-09 13:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  7:07 Preeti U Murthy
2014-10-08  8:07 ` Peter Zijlstra
2014-10-08  9:37   ` Preeti U Murthy
2014-10-08 10:18     ` Peter Zijlstra
2014-10-09  8:20       ` Preeti U Murthy
2014-10-09  8:30         ` Peter Zijlstra
2014-10-09  8:32         ` Peter Zijlstra
2014-10-09 13:06         ` Tejun Heo
2014-10-09 13:47           ` Peter Zijlstra
2014-10-09 13:59             ` Tejun Heo [this message]
2015-04-02  6:56           ` Preeti U Murthy
2015-04-06 17:47             ` Tejun Heo
2015-04-09 21:13               ` Serge E. Hallyn
2015-04-10 14:14                 ` Preeti U Murthy
2014-10-08 14:54 Raghavendra KT
2014-10-09  5:12 ` Preeti U Murthy
2014-10-09  9:42   ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141009135924.GE14387@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=anton@samba.org \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=rjw@rjwysocki.net \
    --cc=svaidy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®