mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Preeti U Murthy <preeti@linux.vnet.ibm.com>
To: "Serge E. Hallyn" <serge@hallyn.com>, Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	lizefan@huawei.com, anton@samba.org, svaidy@linux.vnet.ibm.com,
	rjw@rjwysocki.net, paulmck@linux.vnet.ibm.com, mingo@kernel.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	bharata@linux.vnet.ibm.com
Subject: Re: [PATCH] cpusets: Make cpus_allowed and mems_allowed masks hotplug invariant
Date: Fri, 10 Apr 2015 19:44:02 +0530	[thread overview]
Message-ID: <5527DAAA.7030308@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150409211349.GA28729@mail.hallyn.com>

Hi Serge,

On 04/10/2015 02:43 AM, Serge E. Hallyn wrote:
> On Mon, Apr 06, 2015 at 01:47:35PM -0400, Tejun Heo wrote:
>> Hello, Preeti.
>>
>> On Thu, Apr 02, 2015 at 12:26:32PM +0530, Preeti U Murthy wrote:
>>> By ensuring that the user configured cpusets are untouched, I don't see
>>> how we affect userspace adversely. The expectation usually is that the
>>> kernel keeps track of the user configurations. If anything we would be
>>> fixing an undesired behavior, wouldn't we?
>>
>> The problem is not really about which behavior is "righter" but rather
>> it's fairly likely that there are users / tools out there expecting
>> the current behavior and they wouldn't be too happy to see the
>> behavior flipping underneath them.
>>
>> One way forward would be implementing a knob in cpuset which makes it
>> switch sbetween the old and new behaviors in the legacy hierarchy.
>> It's yucky but doable if absoluately necessary, but what's the reason
>> for you not being able to transition to the unified hierarchy (except
> 
> If the userspace is entirely new then this should work.  The
> unified hierarchy's behavior is not backward-compatible so any old
> software which tried to create cgroups (libcgroup, lxc, etc) will
> not work with it (since it won't, for instance, know to fill in 
> the enabled controllers in every newly created cgroup).
> 
> Preeti, can you confirm that you don't have any need to run any
> legacy programs which use cgroups?  Long as that's the case, new

I don't think I can vouch for this safely. I have posted out a V2 of
this patch adhering to Tejun's first suggestion. IMO that seemed like
a better option.

Regards
Preeti U Murthy


  reply	other threads:[~2015-04-10 14:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08  7:07 Preeti U Murthy
2014-10-08  8:07 ` Peter Zijlstra
2014-10-08  9:37   ` Preeti U Murthy
2014-10-08 10:18     ` Peter Zijlstra
2014-10-09  8:20       ` Preeti U Murthy
2014-10-09  8:30         ` Peter Zijlstra
2014-10-09  8:32         ` Peter Zijlstra
2014-10-09 13:06         ` Tejun Heo
2014-10-09 13:47           ` Peter Zijlstra
2014-10-09 13:59             ` Tejun Heo
2015-04-02  6:56           ` Preeti U Murthy
2015-04-06 17:47             ` Tejun Heo
2015-04-09 21:13               ` Serge E. Hallyn
2015-04-10 14:14                 ` Preeti U Murthy [this message]
2014-10-08 14:54 Raghavendra KT
2014-10-09  5:12 ` Preeti U Murthy
2014-10-09  9:42   ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5527DAAA.7030308@linux.vnet.ibm.com \
    --to=preeti@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=serge@hallyn.com \
    --cc=svaidy@linux.vnet.ibm.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome