* Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
[not found] <tip-7fb0f1de49fc75a0dcec22531f2d0a79fc2fb625@git.kernel.org>
@ 2014-10-28 11:19 ` Andi Kleen
2014-10-28 12:42 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Andi Kleen @ 2014-10-28 11:19 UTC (permalink / raw)
To: akpm, peterz, mingo, bp, eranian, zheng.z.yan, hpa, tglx, josh,
linux-kernel
Cc: linux-tip-commits
> +config PERF_EVENTS_INTEL_UNCORE
> + def_bool y
Why not give it a user name? It should be user configurable.
> + depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
I suspect you disabled it completely.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
2014-10-28 11:19 ` [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore Andi Kleen
@ 2014-10-28 12:42 ` Peter Zijlstra
2014-10-28 12:48 ` Andi Kleen
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2014-10-28 12:42 UTC (permalink / raw)
To: Andi Kleen
Cc: akpm, mingo, bp, eranian, zheng.z.yan, hpa, tglx, josh,
linux-kernel, linux-tip-commits
On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > +config PERF_EVENTS_INTEL_UNCORE
> > + def_bool y
>
> Why not give it a user name? It should be user configurable.
To avoid just that, another more or less pointless config option.
> > + depends on PERF_EVENTS && SUP_SUP_INTEL && PCI
>
> SUP_SUP_INTEL looks wrong. Should be CPU_SUP_INTEL
>
> I suspect you disabled it completely.
Indeed, typo there.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore
2014-10-28 12:42 ` Peter Zijlstra
@ 2014-10-28 12:48 ` Andi Kleen
0 siblings, 0 replies; 3+ messages in thread
From: Andi Kleen @ 2014-10-28 12:48 UTC (permalink / raw)
To: Peter Zijlstra
Cc: akpm, mingo, bp, eranian, zheng.z.yan, hpa, tglx, josh,
linux-kernel, linux-tip-commits
On Tue, Oct 28, 2014 at 01:42:28PM +0100, Peter Zijlstra wrote:
> On Tue, Oct 28, 2014 at 04:19:21AM -0700, Andi Kleen wrote:
> > > +config PERF_EVENTS_INTEL_UNCORE
> > > + def_bool y
> >
> > Why not give it a user name? It should be user configurable.
>
> To avoid just that, another more or less pointless config option.
Good point. We should default to allyesconfig, because obviously everyone
needs everything.
-Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-28 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-7fb0f1de49fc75a0dcec22531f2d0a79fc2fb625@git.kernel.org>
2014-10-28 11:19 ` [tip:perf/urgent] perf/x86: Fix compile warnings for intel_uncore Andi Kleen
2014-10-28 12:42 ` Peter Zijlstra
2014-10-28 12:48 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome