mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] genirq: fix symbol export for __irq_set_affinity
Date: Thu, 18 Dec 2014 14:48:36 -0800	[thread overview]
Message-ID: <20141218144836.0000091d@unknown> (raw)
In-Reply-To: <alpine.DEB.2.11.1412182340300.17382@nanos>

On Thu, 18 Dec 2014 23:42:03 +0100
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Thu, 18 Dec 2014, Jesse Brandeburg wrote:
> > Enabling this function means that kernel drivers can include
> > an initial affinity setting for the interrupt, instead of all
> > interrupts starting out life on CPU0.  It seems to have just
> > been an oversight that it was not included.

> And why needs this to be called from modules? Just because or is there
> a legitimate reason? IOW, you forgot to describe the actual usecase.

As stated above, the use case for my interest is making a network
driver's many interrupt vectors not all show up on CPU0.  Of course a
user can work around this by manually tuning smp_affinity, but I have
seen many reports from users and testers where the performance of the
network was really bad due to all network interrupts on CPU0.

This allows the driver to set a sane default smp_affinity value at
driver load.

Would you instead consider a patch where if a user calls the
set_irq_affinity_hint that the initial affinity is set to the hinted
value?

  reply	other threads:[~2014-12-18 22:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 22:30 Jesse Brandeburg
2014-12-18 22:42 ` Thomas Gleixner
2014-12-18 22:48   ` Jesse Brandeburg [this message]
2014-12-18 23:11     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141218144836.0000091d@unknown \
    --to=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®