mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] genirq: fix symbol export for __irq_set_affinity
Date: Thu, 18 Dec 2014 14:30:31 -0800	[thread overview]
Message-ID: <20141218223031.23847.86103.stgit@jbrandeb-cp2.jf.intel.com> (raw)

The function __irq_set_affinity is referenced by interrupt.h
with static inlines, but if you try to use one of the inlines
in interrupt.h (for instance to call irq_set_affinity) then
compile fails due to a missing symbol, when building modules.

Enabling this function means that kernel drivers can include
an initial affinity setting for the interrupt, instead of all
interrupts starting out life on CPU0.  It seems to have just
been an oversight that it was not included.

This function and the helpers that call it from interrupt.h were
already in the kernel API, but if used would then fail to compile
due to the lack of an export even though already defined via extern.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
CC: Thomas Gleixner <tglx@linutronix.de>

---

Note: The use of EXPORT_SYMBOL_GPL was only because the next
      latest function added to this file (irq_set_affinity_hint)
      also used it.
---
 kernel/irq/manage.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 8069237..8c1a5ad 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -233,6 +233,7 @@ int __irq_set_affinity(unsigned int irq, const struct cpumask *mask, bool force)
 	raw_spin_unlock_irqrestore(&desc->lock, flags);
 	return ret;
 }
+EXPORT_SYMBOL_GPL(__irq_set_affinity);
 
 int irq_set_affinity_hint(unsigned int irq, const struct cpumask *m)
 {


             reply	other threads:[~2014-12-18 22:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 22:30 Jesse Brandeburg [this message]
2014-12-18 22:42 ` Thomas Gleixner
2014-12-18 22:48   ` Jesse Brandeburg
2014-12-18 23:11     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141218223031.23847.86103.stgit@jbrandeb-cp2.jf.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®