mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq: fix symbol export for __irq_set_affinity
Date: Thu, 18 Dec 2014 23:42:03 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1412182340300.17382@nanos> (raw)
In-Reply-To: <20141218223031.23847.86103.stgit@jbrandeb-cp2.jf.intel.com>

On Thu, 18 Dec 2014, Jesse Brandeburg wrote:

> The function __irq_set_affinity is referenced by interrupt.h
> with static inlines, but if you try to use one of the inlines
> in interrupt.h (for instance to call irq_set_affinity) then
> compile fails due to a missing symbol, when building modules.
> 
> Enabling this function means that kernel drivers can include
> an initial affinity setting for the interrupt, instead of all
> interrupts starting out life on CPU0.  It seems to have just
> been an oversight that it was not included.
> 
> This function and the helpers that call it from interrupt.h were
> already in the kernel API, but if used would then fail to compile
> due to the lack of an export even though already defined via extern.

And why needs this to be called from modules? Just because or is there
a legitimate reason? IOW, you forgot to describe the actual usecase.

Thanks,

	tglx

  reply	other threads:[~2014-12-18 22:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 22:30 Jesse Brandeburg
2014-12-18 22:42 ` Thomas Gleixner [this message]
2014-12-18 22:48   ` Jesse Brandeburg
2014-12-18 23:11     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1412182340300.17382@nanos \
    --to=tglx@linutronix.de \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®